Fix for touchEnded triggers twice among other issues with touchEnded/mouseReleased on mobile

[RandomGamingDev]

Resolves #6737

Changes:

Adds an instance variable called touchend to p5 and changed p5.prototype._ontouchend & p5.prototype._onmouseup to function as documented.

On touchscreen

• mouseReleased and touchEnded no longer both trigger if they're both present (same for mouseReleased)
• If either is without the other it doesn't triggers twice anymore

PR Checklist

• npm run lint passes
• Inline documentation is included / updated
• Unit tests are included / updated

[davepagurek]

Does this get called implicitly because the browser triggers a mouse event after the touch event? It'd be helpful adding a comment here explaining if so.

[RandomGamingDev]

I'll add a comment for this and the other PR

[RandomGamingDev]

I've added the comment

[davepagurek]

I think this looks good to me, but could an events steward with more familiarity with the control flow double check? @limzykenneth, @richardegil, @angelabelle, @littlejacinthe, @TanviKumar, @tuminzee

[RandomGamingDev]

I think this looks good to me, but could an events steward with more familiarity with the control flow double check? @limzykenneth, @richardegil, @angelabelle, @littlejacinthe, @TanviKumar, @tuminzee

Could you guys also check if this sorta thing happens to any of the other events for touchscreens? The fact that this happened twice (#6740) might mean that this sorta issue's in other event handlers that deal with touch as well.

[Garima3110]

Hello everyone, I just want to add that I did the tests for this on Safari, and it all looks good. I also tried it out on Chrome on my Android phone, and Safari on my iPhone behaved the same way. So, it seems like things are working fine on both browsers.

[davepagurek]

Thanks for testing this out! I'm going to merge this in now that we've confirmed it also works as expected in different platforms.