Fix for fill artifact in WebGL mode when rendering in LINE mode using beginShape #6827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6826
Changes:
Adds a local variable called
is_line
withinp5.RendererGL.prototype.endShape
and uses that to check whether or not to apply fill.Screenshots of the change:
Here's the sketch demonstrating the issue (This is using the unfixed version of p5.js, but if you'd like to use the fixed version just comment out the default import for the


p5.min.js
import)https://editor.p5js.org/PotatoBoy/sketches/XOezf6_IR
Without the fix:
With the fix:
PR Checklist
npm run lint
passes