Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't continue loop for paused sketches #7334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MartinParrish
Copy link

Resolves n/a

Changes:

  • Updated saveGif to respect the animation’s paused (noLoop) state if it is paused when saveGif is called, preventing it from automatically resuming.

  • This update is similar to the existing handling of pixel density preservation:

const lastPixelDensity = this._pixelDensity;

Motivation: In resource-intensive sketches where noLoop is used, saveGif previously restarted the loop, leading to unnecessary slowdowns during the "Rendering" stage.

Screenshots of the change:

PR Checklist

If the sketch is paused when 'saveGif' is called don't resume looping
within 'saveGif'
Copy link

welcome bot commented Oct 25, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant