Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the contributor docs, removed the broken link #7359

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iamnikhilranjan
Copy link

@iamnikhilranjan iamnikhilranjan commented Nov 4, 2024

Resolves #7220

Changes:

I resolved this by locating the image used in the example within the public/assets folder and replaced all three links which are broken with a single link to the assets folder.

Screenshots of the change:

  • Before
    before

  • After
    after

PR Checklist

Copy link

welcome bot commented Nov 4, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

Copy link
Contributor

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @iamnikhilranjan, for your work on this! The link is breaking because the old website is revamped. I really appreciate your efforts.

contributor_docs/documentation_style_guide.md Outdated Show resolved Hide resolved
Copy link
Contributor

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken links in contributor_docs/documentation_style_guide.md
2 participants