Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build base classes and visitors for custom shapes in p5.js 2.0 #7373

Draft
wants to merge 14 commits into
base: dev-2.0
Choose a base branch
from

Conversation

GregStanton
Copy link
Collaborator

Addresses #6560

Changes:

  • Build base classes (for shapes, contours, shape primitives, and vertices)
  • Build visitor classes (for converting shape primitives to Path2D objects or vertices)

Notes:

  1. This PR may also include an implementation of a point-at-length getter for path-segment primitives.
  2. This PR includes boilerplate for the new user-facing functions; that's a roadmap for a later PR, so it's commented out.

PR Checklist

Note: Since this is a draft PR, I'll update the checklist before submitting it for review. Inline documentation will be included, but I'll hold off on including unit tests covering the new behaviors, since those won't be testable until the next phase of work is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant