[p5.js 2.0]: Color module rewrite - Culori.js #7374
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianamgalindo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7018
Changes:
These are ongoing changes made to the p5.js Color module in an attempt to implement the Culori.js color library.
The changes are based on the current implementation that has been given to the Color.js library on the
dev-2.0branch.The main key differences against the existing p5.Color implementation is the removal of
colorPatternsand_parseInputs. These are usually replaced by pre-existing functions such asconverter,parse, ortoprovided by the external API's (Color.js/ Culori.js)PR Checklist
npm run lintpasses