Add tests for font weight + fix Google Font loading #7426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was already a
textWeight()
method, but it wasn't quite working with variable fonts for a few reasons, so this PR fixes that up.Changes include:
loadFont()
with a CSS font declaration or a URL to a one (e.g. from Google fonts) now works again.@font-face
in the contents.FontFace
descriptors out of the CSS rules so that the font we add to the DOM still supports weight variations declared in the CSStextWeight()
now makes sure that both the 2D context'sfont
property has the weight in it, and also that the canvas element has the rightfontVariationSettings
style applied for Chrome