Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only specify --modules-path when running JavaFX apps #209

Closed
processing-bot opened this issue Jun 19, 2021 · 2 comments
Closed

Only specify --modules-path when running JavaFX apps #209

processing-bot opened this issue Jun 19, 2021 · 2 comments

Comments

@processing-bot
Copy link
Collaborator

Created by: benfry

processing.mode.java.runner.Runner is now specifying the necessary modules for JavaFX (so that it won't complain on startup, but this should only be invoked with real FX2D applications, otherwise there's presumably some overhead.

@processing-bot
Copy link
Collaborator Author

Created by: benfry

See 8e590b6 for the changes. Basically, need to detect when FX2D is in use (look at the parsed code), and include it.

An alternative would be to bump JavaFX out to its own library, and if the sketch imports it, then we do these extra bits. In a similar fashion, we add a means for a Library (renderer) to add its own JVM options. This would also enable us to do the necessary LWJGL tweaks for threading.

@processing-bot
Copy link
Collaborator Author

Created by: benfry

Out of the frying pan, into the fire: #212

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant