-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed buildroot so the project now builds on Ubuntu 18.10 #249
base: master
Are you sure you want to change the base?
Conversation
I also wanted to note that I have successfully booted a generated image with this fork in QEMU (to a point. It gets to loading qt4, then stops with "Failed to find drive with PINN files." even though I have a virtual VFAT sdcard with it on it. I think it's just a QEMU quirk, I'll have to pull out a RPi and make sure, but it looks like images built using this fork are fine to boot and run. |
Thanks for doing this. I will test it out. |
No problem, I had seen some forum posts claiming that qt4-linguist-tools didn't quite solve the .qm generation failures, so I added libqt4-dev as a precaution. The good news is that I did figure out that the error I was experiencing booting it under QEMU is apparently due to QEMU not emulating the storage properly. I decided to give it a go because I was already trying to compile a copy of PINN for my own hobby project and was having so many problems building, so I took it upon myself as a personal challenge to see if I couldn't get this compiling under a newer Ubuntu version! The frustration was worth it though, |
Your timing was impeccable as I was experiencing this same glib problem on a similar OS. |
I found that out the hard way ^_^; I actually started trying to fix it when I ran into the same glib errors with the m4 package, which then took me down a rabbit hole of other updates 😂 It was quite a learning experience and I'm glad I could help out! |
M4_SOURCE = m4-$(M4_VERSION).tar.xz | ||
M4_SITE = $(BR2_GNU_MIRROR)/m4 | ||
M4_LICENSE = GPLv3+ | ||
M4_LICENSE = GPLv3.0+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, why has BISON_LICENSE
changed from GPLv3+
to GPL-3.0+
, but M4_LICENSE
changed from GPLv3+
to GPLv3.0+
?
Hmmmm part 2: https://buildroot.uclibc.org/downloads/manual/manual.html#_infrastructure_for_packages_with_specific_build_systems seems to suggest that the "SPDX short identifier" should be used, and the SPDX page that it links to lists GPL-3.0+
under the "Deprecated License Identifiers" section 😕 🤷♂️
Looks like "it's complicated" so feel free to ignore this comment if you want 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of the changes were lifted from other buildroots (like berryboot's version of buildroot, just copying and pasting) and I didn't really work to ensure that the makefile strings were completely correct while copying them, so I can't attest that they are all correct. I was just trying to get the project compiling tbh, so I was working quick any dirty (and it was past 3-4am by the time I finally got this compiling).
^_^; So my apologies for the confusion on those clerical changes. I'll admit it was due to both my laziness and fatigue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was past 3-4am by the time I finally got this compiling
Been there, done that... 😂
735a52b
to
cba6560
Compare
1de7dee
to
5281e23
Compare
Merged. |
There's a teensy problem with this PR because it prevents the ca-certificates package from generating the certificates to verify SSL connections. |
Aha, I've found the problem... 😃 PINN uses an old version of buildroot, in which the host-tools get installed into I'm now going out for the afternoon, but will try to look at creating a fix later... 🤞 |
Great stuff! |
@lurch - In fact, it was quite easy for me to revert this PR. So I now have a separate branch that will build v3.3a cleanly on Ubuntu 14.04. Which means we can work on these issues separately in parallel again without this holding us up. |
I think it would just confuse, as I'm already half-way into fixing this 😉 |
OK I'll leave as-is. |
Building also needs texinfo, but it doesn't is a pre-requisite. |
Whatever fix I come up with, I'll test and PR it against the HEAD of master 😃 |
I'll need to confirm later with further testing, but I think I've got a local fix for that... |
I don't have texinfo installed in Ubuntu, and I don't recall ever needing it. Is this Debian specific? |
It is mentioned at https://github.com/procount/pinn/blob/master/README_PINN.md#how-to-rebuild-pinn 😉 |
Very curious.
|
$ dpkg -L texinfo | grep '/bin/'
/usr/bin/pdftexi2dvi
/usr/bin/txixml2texi
/usr/bin/texi2any
/usr/bin/pod2texi
/usr/bin/texi2pdf
/usr/bin/texindex
/usr/bin/texi2dvi
/usr/bin/makeinfo |
I made a version with new buildroot, I'm testing it. PR for this is coming soon. |
@raspberrypifan Oh, cool! Should I stop working on my fix and wait for your upgraded buildroot PR to drop? |
I don't know if it works, but I think it works, it's building right now, but I have some network problems now, so downloading takes much time. |
The project now builds on Ubuntu 18.10.
The changeset includes both my original changes, and these new ones:
It requires the following packages host-side:
libqt4-dev
qt4-linguist-tools
bsdtar
This supersedes my previous pull request, as it provides the buildroot with the ability to build under even newer Ubuntu versions than Trusty Tahr.