Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation_fr.ts #345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update translation_fr.ts #345

wants to merge 1 commit into from

Conversation

Norde
Copy link

@Norde Norde commented Jan 10, 2020

Partial update of translation_fr.ts :

  • Almost all strings translated (except those that do not seem to require a translation. See below)
  • Spelling / grammar correction
  • Sentences construction correction
  • Specific french punctuation correction

For future update, are these kind of strings intended to be translated?
ie :
<source>all&amp;usb</source> <translation type="unfinished"></translation>
<location filename="mainwindow.ui" line="474"/> <location filename="mainwindow.ui" line="660"/> <source>N</source>
<location filename="WidgetKeyboard.ui" line="112"/> <source>F2</source>

If not, is it better to leave the tag empty or fill it with the same string as the source?

Partial update of translation_fr.ts :

- Almost all strings translated (except those that do not seem to require a translation. See below)
- Spelling / grammar correction
- Sentences construction correction
- Specific french punctuation correction

For future update, are these kind of strings intended to be translated?
ie :
`        <source>all&amp;usb</source>
        <translation type="unfinished"></translation>`
`        <location filename="mainwindow.ui" line="474"/>
        <location filename="mainwindow.ui" line="660"/>
        <source>N</source>`
`        <location filename="WidgetKeyboard.ui" line="112"/>
        <source>F2</source>`


If not, is it better to leave the <translation> tag empty or fill it with the same string as the source?
@procount
Copy link
Owner

procount commented Jan 10, 2020

The Internationalization will hopefully be improved in a future iteration to allow better translations.

The &amp; instances indicate a shortcut key. I'm not sure if changing the shortcut key because of text language changes will work or not. Changing it also requires that the key is unique in a dialog box. To play safe, I would keep them the same.

Anything that has a translation type of "unfinished" really needs translating if possible. But if it is left empty, I think the English version will be used anyway.
Thanks for the update.

@Norde
Copy link
Author

Norde commented Jan 10, 2020

Thank you for the clarification.
In this case i will check the shortcuts keys and finish updating the translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants