Unit tests covering should.exist() behavior #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests validate whether chai's `should.exist(obj)` behavior still works as expected. Added a set of matching expect() style tests just to confirm that they behave.
|
To be clear, the failing Travis CI tests are the point of the PR. The tests should pass, but I don't know how to make them pass. :-( |
|
@leedm777 Thanks man, I'll take a look at it and see if I can figure something out. |
|
@joshperry Figured anything out yet? |
|
Any progress here? I'm running into a similar problem with a combination of chai, chai-enzyme & dirty-chai. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dirty-chaibreaks theshould[.not].exist()matchers fromchai. I can't quite figure out how it's broken, but I've written some tests that demonstrate it.These tests validate whether chai's
should.exist(obj)behavior stillworks as expected.
Added a set of matching expect() style tests just to confirm that they
behave.