Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

External links anywhere in Jellyfish should open in a new tab #1661

Closed
pdcastro opened this issue Apr 3, 2019 · 5 comments · Fixed by #2282
Closed

External links anywhere in Jellyfish should open in a new tab #1661

pdcastro opened this issue Apr 3, 2019 · 5 comments · Fixed by #2282
Labels
bug Something isn't working ui

Comments

@pdcastro
Copy link

pdcastro commented Apr 3, 2019

Related to #522 and #1047
In a support issue, clicking on links replaces the Jellyfish tab instead of opening a new tab.
Example:
https://jel.ly.fish/#/db3e6be8-d6b3-4348-9708-17058d5b513f

@LucianBuzzo LucianBuzzo added bug Something isn't working ui labels Apr 3, 2019
@LucianBuzzo
Copy link
Contributor

This should be added as a feature of the Markdown component in rendition. We can add the tansformation using markeds renderer option, as described here markedjs/marked#1371 (comment)

@LucianBuzzo
Copy link
Contributor

LucianBuzzo added a commit that referenced this issue Jul 31, 2019
Fixes #1661

Change-type: patch
Signed-off-by: Lucian <lucian.buzzo@gmail.com>
@jellyfish-bot
Copy link

jellyfish-bot commented Aug 4, 2020

This issue has attached support thread https://jel.ly.fish/e72872e1-3de5-4020-a063-afcdbc11f93e

@karaxuna karaxuna reopened this Aug 4, 2020
@karaxuna
Copy link
Contributor

karaxuna commented Aug 4, 2020

@LucianBuzzo
Copy link
Contributor

This is now resolved

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working ui
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants