src: free memory first on URLHost::SetOpaque & URLHost::SetDomain call

Fixes: nodejs#18302
prog1dev · Jan 23, 2018 · 4a2adb0 · 4a2adb0
1 parent bd831b4
commit 4a2adb0
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -110,11 +110,13 @@ class URLHost {
   // These helpers are the easiest solution but we might want to consider
   // just not forcing strings into an union.
   inline void SetOpaque(std::string&& string) {
+    Reset();
     type_ = HostType::H_OPAQUE;
     new(&value_.opaque) std::string(std::move(string));
   }
 
   inline void SetDomain(std::string&& string) {
+    Reset();
     type_ = HostType::H_DOMAIN;
     new(&value_.domain) std::string(std::move(string));
   }