Core #8
Core #8
Conversation
|
I'd change it so that it generates an empty JSON file if it doesn't find the config and gives an error telling used to fill it in. More convenient and better ensures that the user doesn't make any mistakes while making the file. |
|
The issue with empty json file would be the same. We could include a template if it helps? |
|
|
|
@LaVieEstDure @Heasummn can you guys check and approve and one of you merge? |
| def init_bot(): | ||
| """Creates a discord client connection""" | ||
| return discord.Client() | ||
|
|
There was a problem hiding this comment.
Should we be using the discord.bot.ext frameworks? Also this feels like an unpythonic function.
| @client.event | ||
| async def on_ready(): | ||
| """Logs the bot in for operations""" | ||
| print('logged in as {}'.format(client.user.name)) |
There was a problem hiding this comment.
We said we'd support 3.6+, yeah? Should use f-strings where we can then
There was a problem hiding this comment.
I've never used them, can you clone and make the changes? I would like to see.
This PR closes out #7 with the addition of a bot.py file and a settings file. You'll need to make a config.json file. It looks like this: