Support for multiple PhpSpec suites #8
Comments
|
Should be possible 🤔 honestly I never used |
|
But this only confirms my thesis that creating such an extension will give me a lot of knowledge about the phpspec. Thanks for feedback @pamil. |
pamil
added a commit
to Sylius/Sylius
that referenced
this issue
Jan 2, 2019
This PR was merged into the 1.2 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | - | License | MIT Tried to add `proget-hq/phpstan-phpspec` to our PHPStan but ended up reporting proget-hq/phpstan-phpspec#8 and covering our specs with PHPStan and some ignored errors. This led me to find over ten specs which were not run due to class name/namespace/filename mismatches and some wrong `Argument::` calls in specs. Commits ------- 1376307 Update PhpSpec to ^5.0 7913eeb Setup spec paths in autoload-dev in the main package 6b9357d Fix spec classnames / filenames mismatches 8994f2c Make PHPStan for specs passing 6cee10b Make PhpSpec passing after fixing PHPStan warnings a007c90 Remove PHPStan extension for Symfony
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've tried running this extension with Sylius, but the current solution with
specDirseems to be suitable for in-house applications, which aren't divided into chunks and tested by onephpspecrun.It might be worth to use PhpSpec configuration, in our case it's this file: https://github.com/Sylius/Sylius/blob/master/phpspec.yml.dist
The text was updated successfully, but these errors were encountered: