New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve `coords_to_fips` order list error #16

Merged

program-- merged 3 commits into main from jsm-patch-15

Jan 21, 2024

Owner

program-- commented Jan 21, 2024

This PR is required for #15.

The general issue is detailed in the issue, but summarized:

Something (not sure exactly) caused ret_index to become a list rather than a vector, which caused an error when order(ret_index) was called in the return statement.
This PR rectifies that by explicitly ordering by iterating over ret_index and setting the FIPSs into a result vector.

program-- added 3 commits

January 21, 2024 11:24


          coords_to_fips: resolve order list error

3fbcf0f


          docs: update README and NEWS

c6e8a84


          gh: update github workflows

077ed69

program-- merged commit 48e66ea into main

9 checks passed

program-- deleted the jsm-patch-15 branch

May 25, 2024 01:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet