Add more Cocoa bindings #74
Conversation
|
I appreciate you submitting this, but we've just merged a different approach to adding types. Can you try it out? https://github.com/progrium/macdriver/wiki/HowToAddTypes |
|
ahn, I didn't see this before. That would be perfect. :) Thanks. :) |
fserb
force-pushed
the
main
branch
2 times, most recently
from
706dc47
to
b168067
Compare
|
Updated.
|
There was a problem hiding this comment.
Thanks for looking into the new generator. It just landed, so you're the first person to try it out. Seems like you've figured it out, but let me know if you have any feedback.
This looks pretty good overall, but I've added suggestions for a few changes. There's a few comments for things I could also use your feedback on too.
cocoa/NSView.go
Outdated
| @@ -25,6 +25,10 @@ func (v NSView) AddSubviewPositionedRelativeTo(subview NSViewRef, positioned int | |||
| v.AddSubview_positioned_relativeTo_(subview, core.NSUInteger(positioned), relativeTo) | |||
| } | |||
|
|
|||
| func (v NSView) AddSubview(subview NSViewRef) { | |||
| v.Send("addSubview:", subview) | |||
There was a problem hiding this comment.
I think you can update this (and others below) to use the generated methods too:
| v.Send("addSubview:", subview) | |
| v.AddSubview_(subview) |
There was a problem hiding this comment.
Done.
Is there a reason why the gen_ classes don't simply define the functions without _ ?
There was a problem hiding this comment.
Yeah, we still need to decide what to do with that trailing _. We could strip it in the generator, or stop wrapping those and just recommend calling AddSubview_ or whatever directly.
I kept the _ as a replacement for : in the selector -> method naming to avoid conflicts in some cases where it would otherwise be ambiguous. E.g. WKWebView has reload and reload: selectors which would conflict if we named them both Reload in Go:
- (WKNavigation *)reload;
- (IBAction)reload:(id)sender;For now I've updated the wrapper methods that were there before the generator to be aliases to the new methods. The trailing _ does look a little weird, but I don't have another good workaround for the conflicting selectors, so we may just stick with it and stop adding new wrappers to alias those.
There was a problem hiding this comment.
Ahn, I see the problem.
I do like the Set*, what I meant by my comment is that maybe there would be a way to automatically figure out those?
I.e., if there's x and x:, then we should have X() and SetX()? But maybe this is not true? And then otherwise we can just drop the :?
| } | ||
|
|
||
| func (c NSViewController) SetView(v NSView) { | ||
| c.Set("view:", v) |
There was a problem hiding this comment.
Ah yeah, looks like this property is an IBOutlet affected by progrium/macschema#8
I'm gonna try to fix that soon and then we can go back and update this wrapper.
There was a problem hiding this comment.
#79 has a fix to update the generated types here with that IBOutlet fix. I'm going to wait until progrium/macschema#12 is merged though in case there are any changes to the fields.
|
Done all changes above. |
This adds two new classes
NSViewControllerandNSPopover. It also adds some new methods on other classes and updates theNSWindow's*WindowLevelto match MacOSX 11.3.