[Fix] remove TestRunConfig usage from TH Backend (#581) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the repeat endpoint, deprecate the test_run_config endpoints and force the test run execution creation to use selected tests, and not test_run_config_id. * Deprecating unit tests related with test_run_config, creating new endpoint with required selected_tests parameter and ignoring the test_run_config reference, renaming the repeat endpoint method and adding comments. * Updating select_tests logic, moving to a utils file, and adding unit test for the repeat endpoint * Updating comments and adding missing attribution to None for test_run_config_id * Adding missing TODO comment. * Fixing selected_tests logic * Updating the 'repeat' unit test to use more suites to cover more cases. * Removing "/new" endpoint, updating logic of the default test run execution endpoint and updating unit tests, "repeat" endpoint and utils * Adding the new DB column "collection_id" to the TestSuiteExecution table. A DB revision file was created and the code was refactored to use this new info. * Removing unnecessary import
antonio-amjr
requested review from
mikaelhm,
fabiowmm,
ccruzagralopes,
hiltonlima,
gladystonfranca and
rquidute
ccruzagralopes
approved these changes
Oct 20, 2023
rquidute
approved these changes
Oct 20, 2023
hiltonlima
approved these changes
Oct 23, 2023
hiltonlima
approved these changes
Oct 30, 2023
mikaelhm
approved these changes
Nov 6, 2023
|
Tested updated create and repeat test run execution end points. |
raul-marquez-csa
approved these changes
Nov 7, 2023
This was referenced Nov 7, 2023
ccruzagralopes
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Add the repeat endpoint, deprecate the test_run_config endpoints and force the test run execution creation to use selected tests, and not test_run_config_id. * Deprecating unit tests related with test_run_config, creating new endpoint with required selected_tests parameter and ignoring the test_run_config reference, renaming the repeat endpoint method and adding comments. * Updating select_tests logic, moving to a utils file, and adding unit test for the repeat endpoint * Updating comments and adding missing attribution to None for test_run_config_id * Adding missing TODO comment. * Fixing selected_tests logic * Updating the 'repeat' unit test to use more suites to cover more cases. * Removing "/new" endpoint, updating logic of the default test run execution endpoint and updating unit tests, "repeat" endpoint and utils * Adding the new DB column "collection_id" to the TestSuiteExecution table. A DB revision file was created and the code was refactored to use this new info. * Removing unnecessary import
ccruzagralopes
added a commit
that referenced
this pull request
Nov 29, 2023
* Fix prblem with sdk_tests collection using hardcoded paths * Enable github workflows for main branch (#17) * Enable github workflows for main branch * Ignore Dockerfile * mypy: ignore python_testing in sdk_collection * minor linting issues fixed * ignore .devcontainer in spell checker * move .env file back in root * Update reference to fetch_sdk_tests_and_runner.sh * Use `pull_request_target` event to support forks * Update yaml_test_folder.py (#21) * Update yaml_test_folder.py * Update test_sdk_yaml_collection.py * Update unittests.yml Don't run old code for unit tests * [Fix] remove TestRunConfig usage from TH Backend (#581) (#6) * Add the repeat endpoint, deprecate the test_run_config endpoints and force the test run execution creation to use selected tests, and not test_run_config_id. * Deprecating unit tests related with test_run_config, creating new endpoint with required selected_tests parameter and ignoring the test_run_config reference, renaming the repeat endpoint method and adding comments. * Updating select_tests logic, moving to a utils file, and adding unit test for the repeat endpoint * Updating comments and adding missing attribution to None for test_run_config_id * Adding missing TODO comment. * Fixing selected_tests logic * Updating the 'repeat' unit test to use more suites to cover more cases. * Removing "/new" endpoint, updating logic of the default test run execution endpoint and updating unit tests, "repeat" endpoint and utils * Adding the new DB column "collection_id" to the TestSuiteExecution table. A DB revision file was created and the code was refactored to use this new info. * Removing unnecessary import * Set default log level to info, to eliminate chatter from python runner (#23) * Update SDK SHA (#25) * Added support to reset db for test (#28) * Missing submit button (#30) * Updates MessageTypeEnum to include options and message types * Update app/user_prompt_support/user_prompt_manager.py Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * Update app/constants/websockets_constants.py Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Update app/user_prompt_support/user_prompt_manager.py --------- Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Update version * Prompt request refactor (#31) * Refactor to use only 1 enum * Removed unsed import * Fix isort * Adds a new Message prompt request --------- Co-authored-by: raul-marquez-csa <rmarquez@csa-iot.org> * update backend version in FE (#32) * update backend version in FE * Update .version_information * Update .version_information * change ssh to https (#33) * Undo version information update --------- Co-authored-by: Mikael H. Moeller <mikaelhm@apple.com> Co-authored-by: Mikael Møller <mikaelhm@hey.com> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: Raul Marquez <130402456+raul-marquez-csa@users.noreply.github.com> Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> Co-authored-by: raul-marquez-csa <rmarquez@csa-iot.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Remove TestRunConfig #14
Frontend PR counterpart: Updates create and repeat test run execution to match backend changes #13
Removing TestRunConfig usage from TH Backend:
force the test run execution creation to use selected tests, and not test_run_config_id.
Deprecating unit tests related with test_run_config, creating new endpoint with required selected_tests parameter and ignoring the test_run_config reference, renaming the repeat endpoint method and adding comments.
Updating select_tests logic, moving to a utils file, and adding unit test for the repeat endpoint
Updating comments and adding missing attribution to None for test_run_config_id
Adding missing TODO comment.
Fixing selected_tests logic
Updating the 'repeat' unit test to use more suites to cover more cases.
Removing "/new" endpoint, updating logic of the default test run execution endpoint and updating unit tests, "repeat" endpoint and utils
Adding the new DB column "collection_id" to the TestSuiteExecution table. A DB revision file was created and the code was refactored to use this new info.
Removing unnecessary import