Skip to content

Commit

Permalink
PersistentStorageOpCertStore: fix a clang-tidy warning (#29286)
Browse files Browse the repository at this point in the history
`~PersistentStorageOpCertStore` invokes `Finish()`, which invokes `RevertPendingOpCerts()` which is a virtual method.

In this case methods invoked belong to this class so as long as there are no descendants, it's ok.
Make sure there are no descendants by declaring the class final.

Fixes #29239
  • Loading branch information
rojer authored and pull[bot] committed Oct 4, 2023
1 parent aca7b7c commit 1378021
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/credentials/PersistentStorageOpCertStore.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ namespace Credentials {
* to refactors to use `OperationalCertificateStore` and exists as a baseline example
* of how to use the interface.
*/
class PersistentStorageOpCertStore : public OperationalCertificateStore
class PersistentStorageOpCertStore final : public OperationalCertificateStore
{
public:
PersistentStorageOpCertStore() {}
Expand Down

0 comments on commit 1378021

Please sign in to comment.