all-clusters-app: Disable OTA Provider Server (#13454)

* all-clusters-app: Disable OTA Provider Server Having same cluster's client and server in same app is not supported in the zap. Removed OTA provider server from all-clusters-app * Remove OTA Provider server test cases * Remove OTA Provider files from all-clusters-app/mbed CMakeLists.txt * Disable OtaSoftwareUpdateProvider cluster tests for Darwin
project-chip · Dec 5, 2023 · 1536571 · 1536571
1 parent 769d6db
commit 1536571
Show file tree

Hide file tree

Showing 11 changed files with 111 additions and 233 deletions.
diff --git a/examples/all-clusters-app/all-clusters-common/all-clusters-app.zap b/examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
@@ -1408,7 +1408,7 @@
           "mfgCode": null,
           "define": "OTA_PROVIDER_CLUSTER",
           "side": "server",
-          "enabled": 1,
+          "enabled": 0,
           "commands": [
             {
               "name": "QueryImageResponse",

diff --git a/examples/all-clusters-app/esp32/main/CMakeLists.txt b/examples/all-clusters-app/esp32/main/CMakeLists.txt
@@ -60,7 +60,6 @@ set(SRC_DIRS_LIST
                       "${CMAKE_SOURCE_DIR}/third_party/connectedhomeip/src/app/clusters/keypad-input-server"
                       "${CMAKE_SOURCE_DIR}/third_party/connectedhomeip/src/app/clusters/media-playback-server"
                       "${CMAKE_SOURCE_DIR}/third_party/connectedhomeip/src/app/clusters/ota-requestor"
-                      "${CMAKE_SOURCE_DIR}/third_party/connectedhomeip/src/app/clusters/ota-provider"
                       "${CMAKE_SOURCE_DIR}/third_party/connectedhomeip/src/app/clusters/target-navigator-server"
                       "${CMAKE_SOURCE_DIR}/third_party/connectedhomeip/src/app/clusters/thermostat-server"
                       "${CMAKE_SOURCE_DIR}/third_party/connectedhomeip/src/app/clusters/thermostat-user-interface-configuration-server"

diff --git a/examples/all-clusters-app/mbed/CMakeLists.txt b/examples/all-clusters-app/mbed/CMakeLists.txt
@@ -43,7 +43,6 @@ target_include_directories(${APP_TARGET} PRIVATE
                            ${CHIP_ROOT}/src/app
                            ${CHIP_ROOT}/third_party/nlio/repo/include
                            ${GEN_DIR}/all-clusters-app
-                           ${GEN_DIR}/ota-provider-app
                            ${GEN_DIR}/app-common
 )
 
@@ -118,7 +117,6 @@ target_sources(${APP_TARGET} PRIVATE
                ${APP_CLUSTERS}/network-commissioning-old/network-commissioning-ember.cpp
                ${APP_CLUSTERS}/network-commissioning-old/network-commissioning-old.cpp
                ${APP_CLUSTERS}/on-off-server/on-off-server.cpp
-               ${APP_CLUSTERS}/ota-provider/ota-provider.cpp
                ${APP_CLUSTERS}/scenes/scenes.cpp
                ${APP_CLUSTERS}/switch-server/switch-server.cpp
                ${APP_CLUSTERS}/target-navigator-server/target-navigator-server.cpp

diff --git a/src/app/tests/suites/TestDescriptorCluster.yaml b/src/app/tests/suites/TestDescriptorCluster.yaml
@@ -40,7 +40,6 @@ tests:
                   0x001E, # Binding
                   0x001F, # Access Control
                   0x0028, # Basic Information
-                  0x0029, # OTA Software Update Provider
                   0x002A, # OTA Software Update Requestor
                   0x002B, # Localization Configuration
                   0x002E, # Power Source Configuration

diff --git a/src/darwin/Framework/CHIP/templates/clusters-tests.zapt b/src/darwin/Framework/CHIP/templates/clusters-tests.zapt
@@ -210,6 +210,7 @@ CHIPDevice * GetConnectedDevice(void)
 {{#unless (isStrEqual "Access Control" name)}}
 {{#unless (isStrEqual "Basic" name)}}
 {{#unless (isStrEqual "Thermostat" name)}}
+{{#unless (isStrEqual "OTA Software Update Provider" name)}}
 {{#chip_server_cluster_attributes}}
 {{#unless (isStrEqual chipCallback.name "Unsupported")}}
 - (void)testSendCluster{{asUpperCamelCase parent.name}}ReadAttribute{{asUpperCamelCase name}}WithCompletionHandler
@@ -266,6 +267,7 @@ CHIPDevice * GetConnectedDevice(void)
 {{/unless}}
 {{/unless}}
 {{/unless}}
+{{/unless}}
 {{/chip_client_clusters}}
 
 @end
diff --git a/src/darwin/Framework/CHIPTests/CHIPClustersTests.m b/src/darwin/Framework/CHIPTests/CHIPClustersTests.m
diff --git a/zzz_generated/all-clusters-app/zap-generated/IMClusterCommandHandler.cpp b/zzz_generated/all-clusters-app/zap-generated/IMClusterCommandHandler.cpp
diff --git a/zzz_generated/all-clusters-app/zap-generated/PluginApplicationCallbacks.h b/zzz_generated/all-clusters-app/zap-generated/PluginApplicationCallbacks.h