Skip to content

Commit

Permalink
Update and add additional VALCC test scripts (#31243)
Browse files Browse the repository at this point in the history
* Added VCC-1.1 YAML script

* Updated VCC 2.1

* Update VCC 2.1 to match latest spec

* Added VCC 3.1 test script

* Added missing step descriptions in 3.1

* Added 3.2 test script

* Added 3.3 test script

* Fixed check error in 3.3

* Added 4.1 test script

* Added 4.2 test script

* Added 4.3 test script

* Fixed test case number in description

* Added 4.4 test script

* Fixed wrong PICS code used fir test names

* Renamed test YAML to use correct PICS code for name

* Adjusted PICS code for 1.1 YAML script

* Adjusted python scripts to use correct PICS code

* Fixed wrong validation

* Removed unused imports

* Remove prints

* Added 3.4 test script

* Remove unused imports

* Added LevelStep step to 2.1

* Added null handling step to 4.2

* Adjusted 4.3 to match latest test spec

* Fix wrong openDuration in Open command for 4.4

* Update src/app/tests/suites/certification/Test_TC_VALCC_1_1.yaml

* Added LevelStep check to 1.1

* Changing test case skipping to loop

* Minor update to for loop

* Updated 4.3 to match latest test spec

* Restyle

* Added ci PICS for VALCC

* Added missed header

* Added missing feature PICS

* Remove manual PICS

* Fixed invalid PICS
  • Loading branch information
ReneJosefsen authored and pull[bot] committed Feb 1, 2024
1 parent fbf8770 commit 1609228
Show file tree
Hide file tree
Showing 13 changed files with 1,467 additions and 142 deletions.
67 changes: 67 additions & 0 deletions src/app/tests/suites/certification/PICS.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9421,3 +9421,70 @@ PICS:

- label: "Does the device implement the SensorFault event?"
id: BOOLCFG.S.E01

#
#Valve Configuration and Control
#
- label:
"Does the device implement the Valve Configuration and Control cluster
as a server?"
id: VALCC.S

#Features
- label:
"Does the device support the ability to use UTC time is used for time
indications?"
id: VALCC.S.F00

- label:
"Does the device support the ability to setting the specific position
of the valve?"
id: VALCC.S.F01

#Attributes
- label: "Does the device implement the OpenDuration attribute?"
id: VALCC.S.A0000

- label: "Does the device implement the DefaultOpenDuration attribute?"
id: VALCC.S.A0001

- label: "Does the device implement the AutoCloseTime attribute?"
id: VALCC.S.A0002

- label: "Does the device implement the RemainingDuration attribute?"
id: VALCC.S.A0003

- label: "Does the device implement the CurrentState attribute?"
id: VALCC.S.A0004

- label: "Does the device implement the TargetState attribute?"
id: VALCC.S.A0005

- label: "Does the device implement the CurrentLevel attribute?"
id: VALCC.S.A0006

- label: "Does the device implement the TargetLevel attribute?"
id: VALCC.S.A0007

- label: "Does the device implement the DefaultOpenLevel attribute?"
id: VALCC.S.A0008

- label: "Does the device implement the ValveFault attribute?"
id: VALCC.S.A0009

- label: "Does the device implement the LevelStep attribute?"
id: VALCC.S.A000a

#Commands received
- label: "Does the device implement receiving the Open command?"
id: VALCC.S.C00.Rsp

- label: "Does the device implement receiving the Close command?"
id: VALCC.S.C01.Rsp

#Events
- label: "Does the device implement the ValveStateChanged event?"
id: VALCC.S.E00

- label: "Does the device implement the ValveFault event?"
id: VALCC.S.E01
186 changes: 186 additions & 0 deletions src/app/tests/suites/certification/Test_TC_VALCC_1_1.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,186 @@
# Copyright (c) 2024 Project CHIP Authors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: 62.1.1. [TC-VALCC-1.1] Global attributes with server as DUT

PICS:
- VALCC.S

config:
nodeId: 0x12344321
cluster: "Valve Configuration and Control"
endpoint: 1

tests:
- label: "Step 1: Wait for the commissioned device to be retrieved"
cluster: "DelayCommands"
command: "WaitForCommissionee"
arguments:
values:
- name: "nodeId"
value: nodeId

- label: "Step 2: Read the global attribute: ClusterRevision"
command: "readAttribute"
attribute: "ClusterRevision"
response:
value: 1
constraints:
type: int16u

- label: "Step 3a: Read the global attribute: FeatureMap"
command: "readAttribute"
attribute: "FeatureMap"
PICS: ( !VALCC.S.F00 && !VALCC.S.F01 )
response:
value: 0
constraints:
type: bitmap32

- label:
"Step 3b: Given VALCC.S.F00(TS) ensure featuremap has the correct bit
set"
command: "readAttribute"
attribute: "FeatureMap"
PICS: VALCC.S.F00
response:
constraints:
type: bitmap32
hasMasksSet: [0x1]

- label:
"Step 3c: Given VALCC.S.F01(LVL) ensure featuremap has the correct bit
set"
command: "readAttribute"
attribute: "FeatureMap"
PICS: VALCC.S.F01
response:
constraints:
type: bitmap32
hasMasksSet: [0x2]

- label: "Step 4a: Read the global attribute: AttributeList"
PICS: PICS_EVENT_LIST_ENABLED
command: "readAttribute"
attribute: "AttributeList"
response:
constraints:
type: list
contains: [0, 1, 3, 4, 65528, 65529, 65530, 65531, 65532, 65533]

- label: "Step 4a: Read the global attribute: AttributeList"
PICS: "!PICS_EVENT_LIST_ENABLED"
command: "readAttribute"
attribute: "AttributeList"
response:
constraints:
type: list
contains: [0, 1, 3, 4, 65528, 65529, 65531, 65532, 65533]

- label:
"Step 4b: Read the feature dependent(VALCC.S.F00) attribute in
AttributeList"
PICS: VALCC.S.F00
command: "readAttribute"
attribute: "AttributeList"
response:
constraints:
type: list
contains: [2]

- label:
"Step 4c: Read the feature dependent(VALCC.S.F01) attribute in
AttributeList"
PICS: VALCC.S.F01
command: "readAttribute"
attribute: "AttributeList"
response:
constraints:
type: list
contains: [6, 7]

- label:
"Step 4d: Read the feature dependent(VALCC.S.F01) optional attribute
in AttributeList"
PICS: VALCC.S.F01 && VALCC.S.A0008
command: "readAttribute"
attribute: "AttributeList"
response:
constraints:
type: list
contains: [8]

- label:
"Step 4e: Read the feature dependent(VALCC.S.F01) optional attribute
in AttributeList"
PICS: VALCC.S.F01 && VALCC.S.A000a
command: "readAttribute"
attribute: "AttributeList"
response:
constraints:
type: list
contains: [10]

- label:
"Step 4f: TH reads optional (ValveFault) attribute in AttributeList"
PICS: VALCC.S.A0009
command: "readAttribute"
attribute: "AttributeList"
response:
constraints:
type: list
contains: [9]

- label: "Step 5a: Read the global attribute: EventList"
PICS: PICS_EVENT_LIST_ENABLED && !VALCC.S.E00 && !VALCC.S.E01
command: "readAttribute"
attribute: "EventList"
response:
value: []
constraints:
type: list

- label: "Step 5b: Read the optional (ValveStateChanged) event in EventList"
PICS: PICS_EVENT_LIST_ENABLED && VALCC.S.E00
command: "readAttribute"
attribute: "EventList"
response:
constraints:
type: list
contains: [0]

- label: "Step 5c: Read the optional (ValveFault) event in EventList"
PICS: PICS_EVENT_LIST_ENABLED && VALCC.S.E01
command: "readAttribute"
attribute: "EventList"
response:
constraints:
type: list
contains: [1]

- label: "Step 6: Read the global attribute: AcceptedCommandList"
command: "readAttribute"
attribute: "AcceptedCommandList"
response:
constraints:
type: list
contains: [0, 1]

- label: "Step 7: Read the global attribute: GeneratedCommandList"
command: "readAttribute"
attribute: "GeneratedCommandList"
response:
value: []
constraints:
type: list
21 changes: 21 additions & 0 deletions src/app/tests/suites/certification/ci-pics-values
Original file line number Diff line number Diff line change
Expand Up @@ -2656,6 +2656,7 @@ REFALM.S.E00=1
REFALM.S.C00.Rsp=1
REFALM.S.C01.Rsp=1

#Boolean State Configuration
BOOLCFG.S=1
BOOLCFG.S.F00=1
BOOLCFG.S.F01=1
Expand All @@ -2673,3 +2674,23 @@ BOOLCFG.S.E00=1
BOOLCFG.S.E01=1
BOOLCFG.S.C00.Rsp=1
BOOLCFG.S.C01.Rsp=1

#Valve Configuration and Control
VALCC.S=1
VALCC.S.F00=1
VALCC.S.F01=1
VALCC.S.A0000=1
VALCC.S.A0001=1
VALCC.S.A0002=1
VALCC.S.A0003=1
VALCC.S.A0004=1
VALCC.S.A0005=1
VALCC.S.A0006=1
VALCC.S.A0007=1
VALCC.S.A0008=1
VALCC.S.A0009=1
VALCC.S.A000a=1
VALCC.S.E00=1
VALCC.S.E01=1
VALCC.S.C00.Rsp=1
VALCC.S.C01.Rsp=1
Loading

0 comments on commit 1609228

Please sign in to comment.