-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix the "not storing data" mode of ClusterStateCache to actually work. (
#26187) Since we were storing no data, we were computing clusterSize to 0 for all clusters in GetSortedFilters, and then we were not adding any DataVersion filters into our requests at all. The fix is that in "don't store data" mode we still store how big the data would have been, so we can correctly prioritize our DataVersion filters. Without this fix, the change in #26181 fails CI. That CI also acts as a test for this functionality, once #26181 happens.
- Loading branch information
1 parent
afdbc55
commit 2002256
Showing
2 changed files
with
69 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters