Skip to content

Commit

Permalink
The skipping of items without a relevant path was failing to pick ite…
Browse files Browse the repository at this point in the history
…ms with the final element set to None. Now we skip whenever the final element in the path is None. (#26328)

Depending on the exact test setup, paths, including ones that initially come back as `[ None ]`
because the application does not exist, can end up with a prefix (e.g. to run the application
in a network namespace on Linux), so we can't rely on missing applications being represented
by a single-element list.
  • Loading branch information
hicklin authored and pull[bot] committed Nov 2, 2023
1 parent 7bc5ac6 commit 2293616
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/tests/chiptest/test_definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ def Run(self, runner, apps_register, paths: ApplicationPaths, pics_file: str,
# happen if the relevant application does not exist. It's
# non-fatal as long as we are not trying to run any tests that
# need that application.
if len(path) == 1 and path[0] is None:
if path[-1] is None:
continue

# For the app indicated by self.target, give it the 'default' key to add to the register
Expand Down

0 comments on commit 2293616

Please sign in to comment.