Skip to content

Commit

Permalink
Fix minor issue with PICS test step check, and enable tests (#24832)
Browse files Browse the repository at this point in the history
  • Loading branch information
@tehampson @pull
tehampson authored and pull[bot] committed Dec 19, 2023
1 parent 345ad54 commit 2360562
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 46 deletions.
59 changes: 15 additions & 44 deletions scripts/tests/chiptest/__init__.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,50 +59,21 @@ def _GetManualTests() -> Set[ManualTest]:
# for this reason are marked as manual".
#
# We are working to get this list down to 0.
manualtests.add(ManualTest(yaml="OTA_SuccessfulTransfer.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_ACE_1_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_ACE_1_5.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_ACL_2_10.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_ACL_2_7.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_ACL_2_8.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_ACL_2_9.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_APBSC_9_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_BINFO_2_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_CC_6_2.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_CC_6_3.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_CC_8_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_CGEN_2_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_CHANNEL_5_3.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_DGETH_2_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_DGETH_2_2.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_DGGEN_2_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_DGWIFI_2_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_DRLK_2_2.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_DRLK_2_3.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_DRLK_2_5.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_DRLK_2_7.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_LOWPOWER_2_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_LUNIT_3_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_MEDIAINPUT_3_12.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_MEDIAPLAYBACK_6_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_MEDIAPLAYBACK_6_2.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_MEDIAPLAYBACK_6_3.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_MEDIAPLAYBACK_6_4.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_PCC_2_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_PS_2_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_SC_5_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_SC_5_2.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_TSTAT_2_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_TSTAT_2_2.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_TSUIC_2_2.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_WAKEONLAN_4_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_WNCV_2_1.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_WNCV_2_5.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="TestClusterMultiFabric.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="TestCommissionerNodeId.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="TestEvents.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="TestGroupMessaging.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="TestMultiAdmin.yaml", reason="TODO"))
manualtests.add(ManualTest(yaml="Test_TC_ACL_2_10.yaml", reason="TODO Event Not Supported Yet"))
manualtests.add(ManualTest(yaml="Test_TC_ACL_2_7.yaml", reason="TODO Event Not Supported Yet"))
manualtests.add(ManualTest(yaml="Test_TC_ACL_2_8.yaml", reason="TODO Event Not Supported Yet"))
manualtests.add(ManualTest(yaml="Test_TC_ACL_2_9.yaml", reason="TODO Event Not Supported Yet"))
manualtests.add(ManualTest(yaml="TestEvents.yaml", reason="TODO Event Not Supported Yet"))

manualtests.add(ManualTest(yaml="Test_TC_ACE_1_1.yaml", reason="TODO GetCommissionerNodeId Not Supported Yet"))
manualtests.add(ManualTest(yaml="Test_TC_ACE_1_5.yaml", reason="TODO GetCommissionerNodeId Not Supported Yet"))
manualtests.add(ManualTest(yaml="Test_TC_SC_5_1.yaml", reason="TODO GetCommissionerNodeId Not Supported Yet"))
manualtests.add(ManualTest(yaml="Test_TC_SC_5_2.yaml", reason="TODO GetCommissionerNodeId Not Supported Yet"))
manualtests.add(ManualTest(yaml="TestCommissionerNodeId.yaml", reason="TODO GetCommissionerNodeId Not Supported Yet"))

manualtests.add(ManualTest(yaml="TestClusterMultiFabric.yaml", reason="TODO Enum Mismatch"))
manualtests.add(ManualTest(yaml="TestGroupMessaging.yaml", reason="TODO Group Message Not Supported in chip-repl yet"))
manualtests.add(ManualTest(yaml="TestMultiAdmin.yaml", reason="TODO chip-repl hangs on command expected to fail"))

# Failing, unclear why. Likely repl specific, used to pass however first
# failure point seems unrelated. Historically this seems (very?) flaky
Expand Down
4 changes: 2 additions & 2 deletions scripts/tests/chiptest/yamltest_with_chip_repl_tester.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -106,13 +106,13 @@ def _StackShutDown():

# Executing and validating test
for test_step in yaml.tests:
if not test_step.is_pics_enabled:
continue
test_action = runner.encode(test_step)
# TODO if test_action is None we should see if it is a pseudo cluster.
if test_action is None:
raise Exception(
f'Failed to encode test step {test_step.label}')
if not test_action.pics_enabled:
continue

response = runner.execute(test_action)
decoded_response = runner.decode(response)
Expand Down

0 comments on commit 2360562

Please sign in to comment.