Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make struct name fixup work correctly for nested structs. (#34619)
The code that did struct name fixup did not handle nested structs (e.g. struct-typed command fields, or struct-typed struct fields) correctly. In particular, it would not recursively call itself on the value for a field unless it was fixing up the field name. But there might be field names that don't need fixup that have values that are structs whose fields do need name fixup. The fix is to always call StructFieldsNameConverter on field values, and only condition the deletion of the "old name" from the value dictionary on whether the name is being fixed up.
- Loading branch information