Skip to content

Commit

Permalink
Remove MTR_HIDDEN to avoid duplicate visibility attributes
Browse files Browse the repository at this point in the history
  • Loading branch information
ksperling-apple committed Jan 23, 2024
1 parent 82943d1 commit 2e4c97d
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 17 deletions.
1 change: 0 additions & 1 deletion src/darwin/Framework/CHIP/MTRBaseDevice.mm
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@

class MTRDataValueDictionaryCallbackBridge;

MTR_HIDDEN
@interface MTRReadClientContainer : NSObject
@property (nonatomic, readwrite) app::ReadClient * readClientPtr;
@property (nonatomic, readwrite) app::AttributePathParams * pathParams;
Expand Down
2 changes: 0 additions & 2 deletions src/darwin/Framework/CHIP/MTRDefines.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@

#define MTR_EXPORT __attribute__((visibility("default")))

#define MTR_HIDDEN __attribute__((visibility("hidden")))

#ifdef __cplusplus
#define MTR_EXTERN extern "C" MTR_EXPORT
#else
Expand Down
9 changes: 0 additions & 9 deletions src/darwin/Framework/CHIP/MTRDeviceControllerParameters.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ NS_ASSUME_NONNULL_BEGIN
* interfaces inheriting from this one should be used to actually do the
* initialization.
*/
#if !MTR_PER_CONTROLLER_STORAGE_ENABLED
MTR_HIDDEN
#endif
MTR_NEWLY_AVAILABLE
@interface MTRDeviceControllerAbstractParameters : NSObject
- (instancetype)init NS_UNAVAILABLE;
Expand All @@ -46,9 +43,6 @@ MTR_NEWLY_AVAILABLE
* Parameters that can be used to initialize an MTRDeviceController which
* has a node identity.
*/
#if !MTR_PER_CONTROLLER_STORAGE_ENABLED
MTR_HIDDEN
#endif
MTR_NEWLY_AVAILABLE
@interface MTRDeviceControllerParameters : MTRDeviceControllerAbstractParameters

Expand Down Expand Up @@ -92,9 +86,6 @@ MTR_NEWLY_AVAILABLE

@end

#if !MTR_PER_CONTROLLER_STORAGE_ENABLED
MTR_HIDDEN
#endif
MTR_NEWLY_AVAILABLE
@interface MTRDeviceControllerExternalCertificateParameters : MTRDeviceControllerParameters

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,6 @@ MTR_NEWLY_AVAILABLE
@end

// TODO: FIXME: Is this a sane place to put this API?
#if MTR_PER_CONTROLLER_STORAGE_ENABLED
MTR_EXTERN
#else
MTR_HIDDEN
#endif // MTR_PER_CONTROLLER_STORAGE_ENABLED
MTR_NEWLY_AVAILABLE NSSet<Class> * MTRDeviceControllerStorageClasses(void);

NS_ASSUME_NONNULL_END
Expand Down

0 comments on commit 2e4c97d

Please sign in to comment.