Skip to content

Commit

Permalink
Stop updating all submodules during Xcode builds. (#20238)
Browse files Browse the repository at this point in the history
In CI we were first fetching only the submodules we need for Darwin during the
submodules step, then the Xcode build would fetch _all_ submodules.  This took a
very long time.

Change the Xcode script to use the "fetch just the submodules we need"
machinery.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Dec 17, 2023
1 parent 3498e80 commit 3449307
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/darwin/Framework/chip_xcode_build_connector.sh
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ find_in_ancestors() {
fi

# there are environments where these bits are unwanted, unnecessary, or impossible
[[ -n $CHIP_NO_SUBMODULES ]] || git submodule update --init
[[ -n $CHIP_NO_SUBMODULES ]] || scripts/checkout_submodules.py --shallow --platform darwin
if [[ -z $CHIP_NO_ACTIVATE ]]; then
# first run bootstrap/activate in an external env to build everything
env -i PW_ENVSETUP_NO_BANNER=1 PW_ENVSETUP_QUIET=1 bash -c '. scripts/activate.sh'
Expand Down

0 comments on commit 3449307

Please sign in to comment.