Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix some alerts from the LGTM system
Browse files Browse the repository at this point in the history
Signed-off-by: Taras Drozdovskyi <t.drozdovsky@samsung.com>
tdrozdovsky committed Nov 2, 2021

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
1 parent e788c90 commit 38bf407
Showing 14 changed files with 18 additions and 19 deletions.
3 changes: 2 additions & 1 deletion scripts/tools/memory/memdf/df.py
Original file line number Diff line number Diff line change
@@ -32,7 +32,8 @@ def __init__(self, *args, **kwargs):
self[c] = pd.Series()
types = {c: self.dtype[c] for c in self.columns if c in self.dtype}
typed_columns = list(types.keys())
self[typed_columns] = self.astype(types, copy=False)[typed_columns]
self[typed_columns] = self.astype(types, copy=False)[
typed_columns] # lgtm [py/hash-unhashable-value]
self.attrs['name'] = self.name


2 changes: 0 additions & 2 deletions scripts/tools/memory/report_summary.py
Original file line number Diff line number Diff line change
@@ -28,8 +28,6 @@

import sys

import numpy # type: ignore

import memdf.collect
import memdf.report
import memdf.select
2 changes: 1 addition & 1 deletion src/controller/python/chip/ChipBleUtility.py
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@

from __future__ import absolute_import
from __future__ import print_function
from ctypes import *
from ctypes import * # lgtm [py/polluting-import]
from .ChipUtility import ChipUtility


2 changes: 1 addition & 1 deletion src/controller/python/chip/ChipBluezMgr.py
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@
import uuid
import queue

from ctypes import *
from ctypes import CFUNCTYPE, PYFUNCTYPE, c_void_p, c_int

try:
from gi.repository import GObject
2 changes: 1 addition & 1 deletion src/controller/python/chip/ChipCommissionableNodeCtrl.py
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@

from __future__ import absolute_import
from __future__ import print_function
from ctypes import *
from ctypes import c_void_p, c_uint32
from .ChipStack import *
from .exceptions import *

2 changes: 1 addition & 1 deletion src/controller/python/chip/ChipCoreBluetoothMgr.py
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@

from __future__ import absolute_import
from __future__ import print_function
from ctypes import *
from ctypes import * # lgtm [py/polluting-import]
from Foundation import *

import logging
6 changes: 3 additions & 3 deletions src/controller/python/chip/ChipDeviceCtrl.py
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@
from __future__ import absolute_import
from __future__ import print_function
import asyncio
from ctypes import *
from ctypes import * # lgtm [py/polluting-import]
from .ChipStack import *
from .interaction_model import delegate as im
from .exceptions import *
@@ -334,11 +334,11 @@ def DeviceAvailableCallback(device, err):

# The callback might have been received synchronously (during self._ChipStack.Call()).
# Check if the device is already set before waiting for the callback.
if returnDevice.value == None:
if returnDevice.value is None:
with deviceAvailableCV:
deviceAvailableCV.wait()

if returnDevice.value == None:
if returnDevice.value is None:
raise self._ChipStack.ErrorToException(CHIP_ERROR_INTERNAL)
return returnDevice

2 changes: 1 addition & 1 deletion src/controller/python/chip/ChipStack.py
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@
import platform
import logging
from threading import Lock, Event, Condition
from ctypes import *
from ctypes import * # lgtm [py/polluting-import]
from .ChipUtility import ChipUtility
from .exceptions import *

2 changes: 1 addition & 1 deletion src/controller/python/chip/ChipUtility.py
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@
from __future__ import absolute_import
from __future__ import print_function
import binascii
from ctypes import *
from ctypes import c_void_p, c_byte


class ChipUtility(object):
2 changes: 1 addition & 1 deletion src/controller/python/chip/ble/library_handle.py
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
#

import chip.native
import ctypes
import ctypes # lgtm [py/import-and-import-from]
from ctypes import c_bool, c_void_p, c_char_p, c_uint32, py_object
from chip.ble.types import DeviceScannedCallback, ScanDoneCallback

4 changes: 2 additions & 2 deletions src/controller/python/chip/clusters/Command.py
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@
#

from asyncio.futures import Future
import ctypes
import ctypes # lgtm [py/import-and-import-from]
from dataclasses import dataclass
from typing import Type
from ctypes import CFUNCTYPE, c_char_p, c_size_t, c_void_p, c_uint32, c_uint16, c_uint8, py_object
@@ -74,7 +74,7 @@ def _handleResponse(self, path: CommandPath, status: Status, response: bytes):
self._future.set_result(None)
else:
# If a type hasn't been assigned, let's auto-deduce it.
if (self._expect_type == None):
if (self._expect_type is None):
self._expect_type = FindCommandClusterObject(False, path)

if self._expect_type:
4 changes: 2 additions & 2 deletions src/controller/python/chip/clusters/__init__.py
Original file line number Diff line number Diff line change
@@ -23,5 +23,5 @@
"""Provides Python APIs for CHIP."""
from . import Command
from . import Attribute
from .Objects import *
from . import CHIPClusters
from .Objects import * # lgtm [py/polluting-import]
from . import CHIPClusters
2 changes: 1 addition & 1 deletion src/controller/python/chip/interaction_model/__init__.py
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@

from chip.exceptions import ChipStackException

__all__ = ["IMDelegate", "Status", "InteractionModelError"]
__all__ = ["Status", "InteractionModelError"]


class Status(enum.IntEnum):
2 changes: 1 addition & 1 deletion src/controller/python/chip/interaction_model/delegate.py
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@
from abc import abstractmethod
from construct import Struct, Int64ul, Int32ul, Int16ul, Int8ul
from ctypes import CFUNCTYPE, c_void_p, c_uint32, c_uint64, c_uint8, c_uint16, c_ssize_t
import ctypes
import ctypes # lgtm [py/import-and-import-from]
import chip.native
import threading
import chip.tlv

0 comments on commit 38bf407

Please sign in to comment.