[todo] Add refs to github issue for TODO: in v1_triage_split_4 (#14608)

* [todo] Add refs to github issue for TODO: in v1_triage_split_4 * [todo] Add refs to github issue for TODO: in v1_triage_split_4 * restyle
project-chip · Mar 2, 2022 · 4009100 · 4009100
1 parent da35248
commit 4009100
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 13 deletions.
diff --git a/examples/chip-tool/commands/pairing/Commands.h b/examples/chip-tool/commands/pairing/Commands.h
@@ -196,7 +196,7 @@ void registerCommandsPairing(Commands & commands, CredentialIssuerCommands * cre
         make_unique<PairOnNetworkDeviceType>(credsIssuerConfig),
         make_unique<PairOnNetworkDeviceType>(credsIssuerConfig),
         make_unique<PairOnNetworkInstanceName>(credsIssuerConfig),
-        // TODO - enable CommissionedListCommand once DNS Cache is implemented
+        // TODO(#13973) - enable CommissionedListCommand once DNS Cache is implemented
         //        make_unique<CommissionedListCommand>(),
         make_unique<StartUdcServerCommand>(credsIssuerConfig),
         make_unique<OpenCommissioningWindowCommand>(credsIssuerConfig),

diff --git a/examples/ota-provider-app/ota-provider-common/BdxOtaSender.cpp b/examples/ota-provider-app/ota-provider-common/BdxOtaSender.cpp
@@ -105,7 +105,7 @@ void BdxOtaSender::HandleTransferSessionOutput(TransferSession::OutputEvent & ev
         chip::System::PacketBufferHandle blockBuf = chip::System::PacketBufferHandle::New(bytesToRead);
         if (blockBuf.IsNull())
         {
-            // TODO: AbortTransfer() needs to support GeneralStatusCode failures as well as BDX specific errors.
+            // TODO(#13981): AbortTransfer() needs to support GeneralStatusCode failures as well as BDX specific errors.
             mTransfer.AbortTransfer(StatusCode::kUnknown);
             return;
         }

diff --git a/src/app/tests/suites/TV_ApplicationBasicCluster.yaml b/src/app/tests/suites/TV_ApplicationBasicCluster.yaml
@@ -23,7 +23,7 @@ tests:
       cluster: "DelayCommands"
       command: "WaitForCommissionee"
 
-    # TODO: Support chars validation
+    # TODO(#14054): Support chars validation
     - label: "Read attribute vendor name"
       command: "readAttribute"
       attribute: "vendor name"
@@ -36,7 +36,7 @@ tests:
       response:
           value: 1
 
-    # TODO: Support chars validation
+    # TODO(#14054): Support chars validation
     - label: "Read attribute application name"
       command: "readAttribute"
       attribute: "application name"
@@ -62,7 +62,7 @@ tests:
       response:
           value: { catalogVendorId: 123, applicationId: "applicationId" }
 
-    # TODO: Support chars validation
+    # TODO(#14054): Support chars validation
     - label: "Read attribute application version"
       command: "readAttribute"
       attribute: "application version"

diff --git a/src/app/zap-templates/zcl/data-model/chip/general-diagnostics-cluster.xml b/src/app/zap-templates/zcl/data-model/chip/general-diagnostics-cluster.xml
@@ -71,7 +71,7 @@ limitations under the License.
     <item name="FabricConnected" type="BOOLEAN"/>
     <item name="OffPremiseServicesReachableIPv4" type="BOOLEAN" isNullable="true"/>
     <item name="OffPremiseServicesReachableIPv6" type="BOOLEAN" isNullable="true"/>
-    <!-- TODO: HWADR not supported yet -->
+    <!-- TODO(#14075): HWADR not supported yet -->
     <item name="HardwareAddress" type="OCTET_STRING" length="8"/>
     <item name="Type" type="InterfaceType"/>
   </struct>

diff --git a/src/controller/CHIPDeviceController.cpp b/src/controller/CHIPDeviceController.cpp
@@ -777,7 +777,7 @@ CHIP_ERROR DeviceCommissioner::EstablishPASEConnection(NodeId remoteDeviceId, Re
     err = InitializePairedDeviceList();
     SuccessOrExit(err);
 
-    // TODO: We need to specify the peer address for BLE transport in bindings.
+    // TODO(#13940): We need to specify the peer address for BLE transport in bindings.
     if (params.GetPeerAddress().GetTransportType() == Transport::Type::kBle ||
         params.GetPeerAddress().GetTransportType() == Transport::Type::kUndefined)
     {

diff --git a/src/platform/Linux/ConnectivityManagerImpl.cpp b/src/platform/Linux/ConnectivityManagerImpl.cpp
@@ -985,7 +985,7 @@ void ConnectivityManagerImpl::_ConnectWiFiNetworkAsyncCallback(GObject * source_
             DeviceLayer::SystemLayer().ScheduleLambda([this_]() {
                 if (mpConnectCallback != nullptr)
                 {
-                    // TODO: Replace this with actual thread attach result.
+                    // TODO(#14175): Replace this with actual thread attach result.
                     this_->mpConnectCallback->OnResult(NetworkCommissioning::Status::kUnknownError, CharSpan(), 0);
                     this_->mpConnectCallback = nullptr;
                 }
@@ -997,7 +997,7 @@ void ConnectivityManagerImpl::_ConnectWiFiNetworkAsyncCallback(GObject * source_
             DeviceLayer::SystemLayer().ScheduleLambda([this_]() {
                 if (this_->mpConnectCallback != nullptr)
                 {
-                    // TODO: Replace this with actual thread attach result.
+                    // TODO(#14175): Replace this with actual thread attach result.
                     this_->mpConnectCallback->OnResult(NetworkCommissioning::Status::kSuccess, CharSpan(), 0);
                     this_->mpConnectCallback = nullptr;
                 }

diff --git a/src/platform/Linux/NetworkCommissioningWiFiDriver.cpp b/src/platform/Linux/NetworkCommissioningWiFiDriver.cpp
@@ -32,9 +32,9 @@ namespace DeviceLayer {
 namespace NetworkCommissioning {
 
 #if CHIP_DEVICE_CONFIG_ENABLE_WPA
-// TODO: Here, most interfaces are just calling ConnectivityManager interfaces, this is because the ConnectivityProvides some
-// bootstrap code for the wpa_supplicant. However, we can wrap the wpa_supplicant dbus api directly (and remove the related code in
-// ConnectivityManagerImpl).
+// TODO(#14172): Here, most interfaces are just calling ConnectivityManager interfaces, this is because the ConnectivityProvides
+// some bootstrap code for the wpa_supplicant. However, we can wrap the wpa_supplicant dbus api directly (and remove the related
+// code in ConnectivityManagerImpl).
 namespace {
 constexpr char kWiFiSSIDKeyName[]        = "wifi-ssid";
 constexpr char kWiFiCredentialsKeyName[] = "wifi-pass";

diff --git a/src/transport/SessionManager.cpp b/src/transport/SessionManager.cpp
@@ -709,7 +709,7 @@ void SessionManager::ExpiryTimerCallback(System::Layer * layer, void * param)
 {
     SessionManager * mgr = reinterpret_cast<SessionManager *>(param);
 #if CHIP_CONFIG_SESSION_REKEYING
-    // TODO(#2279): session expiration is currently disabled until rekeying is supported
+    // TODO(#14217): session expiration is currently disabled until rekeying is supported
     // the #ifdef should be removed after that.
     mgr->mSecureSessions.ExpireInactiveSessions(System::SystemClock().GetMonotonicTimestamp(),
                                                 System::Clock::Milliseconds32(CHIP_PEER_CONNECTION_TIMEOUT_MS));