Skip to content

Commit

Permalink
Squashed commit of the following:
Browse files Browse the repository at this point in the history
commit f4903e013fc2a84adebbd44e10b573527c5e8d49
Merge: 9c811b19d2 28231261e6
Author: Austin Bozowski <bozowski@google.com>
Date:   Fri Feb 2 01:39:03 2024 -0800

    Merge branch 'project-chip:master' into idt_dev

commit 9c811b19d2cd883ead0d41bc2d809aa9cd4cfff0
Author: Austin Bozowski <bozowski@google.com>
Date:   Fri Feb 2 01:23:15 2024 -0800

    Move feature code to its own package

commit ae4d6dfefabbef89b8bf4bcf63515f9649f435b3
Author: Austin Bozowski <bozowski@google.com>
Date:   Fri Feb 2 01:02:10 2024 -0800

    README

commit cb9e5c556fc1fc07fcff56679f9e480f835ef13c
Author: Austin Bozowski <bozowski@google.com>
Date:   Fri Feb 2 00:04:09 2024 -0800

    Lic headers

commit faf07f30665c32db58a610a20c345f5babea2bc6
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 23:53:09 2024 -0800

    Add back compilers for tcpdump

commit 7455256e452ff7cae13948cefd5247cb38d80c51
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 23:46:47 2024 -0800

    Comments

commit 6dac32c4b0862b491ba7429f5b6b8072a60f368a
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 22:41:03 2024 -0800

    Cleanup

commit cfc536502eb1c77c33c34d53c9e0c13e81d65b58
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 19:43:39 2024 -0800

    Thread sniff pcap in output

commit 0a5ec755a11e76037ff21efa678ef35b44d45776
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 18:41:48 2024 -0800

    Cleanup

commit c8e17341f2d414a62d418886d7371f55f0a3aaab
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 18:39:52 2024 -0800

    Cleanup

commit 72adf9448697b488c7ed906aa239052df7daf4ea
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 18:28:36 2024 -0800

    Move loader to utils

commit af70f7fa550f3cfaec8ab3987ba3cccf585ad17f
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 18:24:59 2024 -0800

    Nit

commit 951dc21f754e719a91b6f0b693ae942aab58d371
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 18:17:51 2024 -0800

    Sniffer

commit 073f19a185cbca89bac65c1bfdf2f5605a0a298e
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 15:56:07 2024 -0800

    Fix path issue

commit 894dfb386d6908dc6e6b78754bec7327bf9d7813
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 14:23:22 2024 -0800

    Refactor setup

commit 5d0b73347bd94c9f597e96955f17bb827991c15d
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Feb 1 13:46:18 2024 -0800

    Create setup CLI infra

commit 9c48c632bb7c465891e0d845b9a62fe393162994
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 31 22:13:39 2024 -0800

    THREAD SNIFF

commit e8e25399f9ca07d0aeb9028cae8a8daf1ff318d2
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 31 21:44:42 2024 -0800

    Use prebuilt firmware for sniffer

commit 10cc469aaa3fb31b57ca362310fdefb6bcc2bbf1
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 31 04:10:54 2024 -0800

    Sniffer

commit 970e517bc73ed6c0750e541d9677cead91628e03
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 31 03:06:54 2024 -0800

    Flash

commit 7a09da8f70072fa9a20abc5c68ebf52e8f0a7dc9
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 31 02:59:24 2024 -0800

    Notes

commit 5d9bb36d59a030ab48f9f328ea2223ec92649de3
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 31 02:40:13 2024 -0800

    Board config

commit 0aa01aeab75569136ec4f24a8acd33302b4e7971
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 31 01:53:04 2024 -0800

    Pyocd install

commit 0985dfc93aaf555375ca82ad5867cbc017f44a3a
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 30 23:29:46 2024 -0800

    Refactor scripts

commit 9c667bfbf123c8ea70bc879e4bef06ad92048114
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 30 15:24:50 2024 -0800

    Notes for thread

commit 9a389c8b51f2feb0d33ded78c16af64424013b02
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 30 15:07:14 2024 -0800

    Fixes for linux

commit f824305efb440232913e29bedbce8484c945054d
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 30 12:30:36 2024 -0800

    Documentation

commit 3a90b3d216aaff9ddf9a6292e3a89e95ac030420
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 30 12:24:25 2024 -0800

    Refactor aliases

commit efae25569b049331f73996dcd2ec2867b753b4bf
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 30 12:18:31 2024 -0800

    Reorganize scripts

commit 0b0a0490f6c9204a9014320d570e16e38b232ae7
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 30 12:06:00 2024 -0800

    Rename alias

commit 7bcc9ad6abd52452b9230994275f2afd97c34ca2
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 30 01:46:03 2024 -0800

    Nit

commit f134f40bee49fd8e03a9a0e2bd81c3c1e767f9e3
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 30 01:45:01 2024 -0800

    More stray proc protection

commit f6b04c3d10f1f2dcbab3adba6718e42e5bc73098
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 30 00:49:05 2024 -0800

    Log errors

commit 2bffdbfa92c5de2bf3f23531339d56d678c8ec83
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 30 00:43:35 2024 -0800

    PID reuse protection

commit 3421f5ed3825a84f3b6f93201141c0a9df052080
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 23:45:46 2024 -0800

    Lint

commit 386399320b4ddbe35667fda5b5db2752a274d003
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 23:39:16 2024 -0800

    Fill paragraph

commit 0118b5e0e24056e102160b62f3ebf386e1eeb75f
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 23:35:42 2024 -0800

    DNS SD cleanup

commit 30e0f449e0dc4aace7fcd5fcb7a1b1234a27f3ad
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 21:58:54 2024 -0800

    Android pcap observer

commit 7e5ebc0970b0ae1e151d96b3f50defc1aad09588
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 18:45:51 2024 -0800

    TODO

commit 0535320b4902322cee268717db4fc20004531632
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 18:41:51 2024 -0800

    TODO

commit 3bef0e6899a8a2c0e6b143f9857a5cba09f8d914
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 18:39:33 2024 -0800

    TODO

commit 2d02ca1077651db30f21a4a943477f9027bcbbcc
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 18:31:51 2024 -0800

    Comments

commit b0c9d5bd533426967e429afc6824c4f20a956581
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 18:29:49 2024 -0800

    Refactor

commit f48cfbf3afe8d4216d9836060797d2e573228ce4
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 18:27:45 2024 -0800

    Refactor

commit 9ada93993c53b473aa2dc3ed9dc86ec136e1313a
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 18:16:53 2024 -0800

    Quality

commit fae354fc95a0bc53494a2c9addda39ca0db372c1
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 18:05:23 2024 -0800

    Refactor

commit 9d2d0c9a8cda6d84410c9fb0582624fdad37a693
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 16:05:17 2024 -0800

    Make advertise options on commandline

commit c378a1921d7cd6f123c8b7c79dc727b712aa444f
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 29 13:56:24 2024 -0800

    Make host ips impl better

commit 3317d170e60cd41fb461ee08af06119d1f3efe0b
Author: Austin Bozowski <bozowski@google.com>
Date:   Fri Jan 26 15:34:32 2024 -0800

    Refactor dns-sd

commit 8cf63b01b47c6733b10bea69e36d60a4b9f3d3a7
Author: Austin Bozowski <bozowski@google.com>
Date:   Fri Jan 26 15:19:33 2024 -0800

    Split parsers and browsers for dns-sd

commit af2b5f6ed58bd9e9f52eacb9bd60fe4a05af945f
Author: Austin Bozowski <bozowski@google.com>
Date:   Fri Jan 26 15:08:04 2024 -0800

    Use fill paragraph instead of on dedent

commit 838d050248230d41e3da792a16b5c1c2fc8f8cbe
Author: Austin Bozowski <bozowski@google.com>
Date:   Fri Jan 26 14:58:16 2024 -0800

    Notes

commit 2d01cb02b0518c2b4c78b53395c6f818ece67dc5
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 24 17:06:33 2024 -0800

    Build thread on Linux

commit 886acfdb4356b76bfb71322193fb3b95a2bb7a7b
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 24 15:56:44 2024 -0800

    Nit

commit b30ed5b4c5fc625a87e231cbf69ddc068e029d96
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 24 15:54:08 2024 -0800

    Add v6 addr type info to discover

commit 5e1a50f703106812df1a806e1763518c0d396007
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 24 11:32:04 2024 -0800

    Clean todo

commit fa19822f56611dfe4c8142d180fed8010b23ab09
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 24 11:25:57 2024 -0800

    Add strong typing to functions in loader

commit fc8231a1dc8c79659135e3912024f3ec34577b8b
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 23 17:13:12 2024 -0800

    Make loader strong type checking

commit 09216366d887fc00d6ea5d329d15ee0ee533a88e
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 23 16:35:36 2024 -0800

    End advertisement gracefully

commit 5b125abe5b3a19fa563a11e46256a5287aaba10b
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 23 16:22:38 2024 -0800

    Debug logs

commit 977f775e172242be3701a2ed7403af59f0c79af8
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 23 16:09:19 2024 -0800

    Support dns-sd advertise on linux

commit bb34dee235049ac878ec22f7ee0a5ab4744d6c18
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 23 13:57:16 2024 -0800

    Centralize error reporting

commit e62c9fa0f82ef4f33cd4618eb981dbdc5aa1e97a
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 22:00:06 2024 -0800

    Nit

commit 88a13ed40df47df64bfebea4cb260e952ad3fc10
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 18:26:26 2024 -0800

    Add help text to host dependencies errors

commit 8492eb2492bcf855628ff17b99f632305bd23d52
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 17:41:20 2024 -0800

    Replace map with list comprehension

commit 20dd2d64c6cfab8e3c8b6f74ca5473111f3265b8
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 17:37:12 2024 -0800

    Replace loop with list comprehension

commit 91617b29fd8eeb96a156a0932e405230cd9a106f
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 15:55:36 2024 -0800

    Refactor

commit 3d48c800188d1cb58cb232cb9f8b25e0b1b6fe67
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 15:50:45 2024 -0800

    Add version info

commit 65a4709c1f45afbe26b70cdc8310d933a51d03dc
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 15:41:41 2024 -0800

    Add width to macOS monitor mode

commit 30924b6da7e27dfa9d2fcebed34d1b8ffbe4040f
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 14:06:00 2024 -0800

    Refactor

commit 357b29038e8ddf7cc3c16f896f964bcd07abe74e
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 14:01:36 2024 -0800

    Refactor

commit 2474acdfaacccf7217978d735b879b00d31302db
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 13:51:18 2024 -0800

    Make advertise mac addr dynamic

commit fd96ec87c16fa77786638fcf0d5b26af51d95911
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 13:37:22 2024 -0800

    Make probe resolve on both v4 and v6 broadcast addr

commit b4e7e74bf06c90ffa073903fc93774e40734b9d7
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 13:23:49 2024 -0800

    Split v4 and v6 browsing logs

commit b63d261f3971dbd7d6a630a1510dbf7bbac0d191
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 12:38:27 2024 -0800

    DNSSD browse both v4 and v6 and display to user

commit ace1e7b839ea9c56439ba70206292c36b2f1f833
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 11:11:39 2024 -0800

    Make Android device selection resilient to edge case crash

commit 72970bdb2cc29b448d2e262bf0a2a965b26c29e1
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 22 10:50:30 2024 -0800

    Fix bug when checking current host wifi band

commit 77c5a62d01000d09102633d27d0c781390947852
Author: Austin Bozowski <bozowski@google.com>
Date:   Sat Jan 20 14:52:07 2024 -0800

    Add vid pid filter to discover

commit 13a67eba728b4edb1ce27bc164cf09998125b858
Author: Austin Bozowski <bozowski@google.com>
Date:   Fri Jan 19 13:51:39 2024 -0800

    Manually pull HCI logs now that bugreport is disabled

commit b0cf0712686e37d05a10db351285fb346a9e008c
Author: bozowski <bozowski@google.com>
Date:   Thu Jan 18 01:43:11 2024 -0800

    README

commit 25224c97483311f3b224f7ea1fb9bd0408b51bb4
Author: bozowski <bozowski@google.com>
Date:   Thu Jan 18 01:32:49 2024 -0800

    Linux monitor mode

commit 6cfbe56cc31c89f42f1acc71e711179d119ebc46
Author: bozowski <bozowski@google.com>
Date:   Thu Jan 18 00:45:21 2024 -0800

    Linux impls

commit a05fc985d2a6050bc9fef931a65623252412998b
Author: bozowski <bozowski@google.com>
Date:   Wed Jan 17 15:30:24 2024 -0800

    Linux wifi channel

commit 9a5378fc9b709b0d295e4b4b3b4a6b0c96d7138f
Author: bozowski <bozowski@google.com>
Date:   Wed Jan 17 14:37:37 2024 -0800

    Nit

commit d5cd6f525cf83b9bd4adb29456bceb675dbf9190
Author: bozowski <bozowski@google.com>
Date:   Wed Jan 17 14:24:46 2024 -0800

    Log

commit 103e523ffa489a9c48e23d27eaecf4c93e95e454
Author: bozowski <bozowski@google.com>
Date:   Wed Jan 17 14:23:29 2024 -0800

    bug

commit 2c7aac54206bf598945ad91d049924c8eccd350d
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 17 11:38:22 2024 -0800

    Readme

commit fe0b06a0d77b8301329d916fb4705b72df81d546
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 17 11:33:54 2024 -0800

    Cleanup

commit 9e6056a9f90dcb5e19a59c4efc94c34b64918a38
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 16 23:31:08 2024 -0800

    README

commit 282526583643282726d42902f95def7971973fc1
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 16 12:41:11 2024 -0800

    Nit

commit 99502dd2450575f23535c2919f06f580b6525fc2
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 16 12:32:06 2024 -0800

    Thread

commit 498239d3ef04591831016d0d882a7929e4077fc8
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 16 12:11:42 2024 -0800

    Thread

commit 788e72e95a1abe21abae115861b7cd477f01a2ab
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 16 11:18:26 2024 -0800

    Parse airport output path

commit 6553de8b6c49d10ae33d105ac8c197162c74e634
Author: Austin Bozowski <bozowski@google.com>
Date:   Sun Jan 14 21:58:03 2024 -0800

    Monitor mode

commit b596e92b74a498b6dc7a59b822d1ac8c51de91d5
Author: Austin Bozowski <bozowski@google.com>
Date:   Sun Jan 14 21:51:06 2024 -0800

    Monitor mode

commit 5d38e54ab941defdf1484885376d2b38c4c7d938
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 10 15:37:41 2024 -0800

    Refactor host utils

commit e51e93a02152f9090975f44947b044ee15af2061
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 9 13:25:39 2024 -0800

    Missing refactor after merge

commit b2f3accccdf10040cc2a519b1d8aa4c54dcfa872
Merge: bc603126df 9b1716b4ac
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 9 12:57:13 2024 -0800

    Merge pull request #229 from aBozowski/idt_feature/monitor_mode_0

    Merge monitor mode

commit 9b1716b4ac1795b4aa9df39ef0ba31198333760e
Merge: c7879df0aa bc603126df
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 9 12:57:05 2024 -0800

    Merge branch 'idt_dev' into idt_feature/monitor_mode_0

commit c7879df0aa4c5029b13709d0b980c60c300e6a98
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 9 12:43:58 2024 -0800

    Merge dev and resolve conflicts

commit bc603126df68750eb7822433105b2e5212113b79
Merge: dfea190efb a2c88cf7d4
Author: Austin Bozowski <bozowski@google.com>
Date:   Tue Jan 9 12:38:09 2024 -0800

    Merge branch 'project-chip:master' into idt_dev

commit dfea190efb385b9fcc293e4761585f269afad129
Merge: f6dbeaea69 04141d311b
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 8 15:34:49 2024 -0800

    Merge pull request #232 from aBozowski/idt_feature/advertise_dns-sd

    Merge advertise dns-sd

commit f6dbeaea69e5d0953a9fe23681667425ee51fc01
Merge: 6ab2cada49 a9f1816964
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 8 15:34:34 2024 -0800

    Merge pull request #230 from aBozowski/idt_feature/play_services_prescriptive1

    Merge prescriptive analysis

commit 6ab2cada4986e1809409b4481c9ea363561cabea
Merge: b02504aeed a7d2de6c62
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 8 15:34:25 2024 -0800

    Merge pull request #231 from aBozowski/idt_feature/thread_network_0

    Merge thread

commit d2f23f6c4033cce2dc63dd283907803e701410bb
Merge: 2866b3a199 2544b6e416
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 8 15:19:16 2024 -0800

    Merge pull request #228 from aBozowski/master

    Update monitor mode

commit 04141d311bf8dbcac1c60a46f7b7d0eb2ec86736
Merge: ad6311927c a50f95964f
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 8 15:15:52 2024 -0800

    Merge branch 'project-chip:master' into idt_feature/advertise_dns-sd

commit b02504aeed4e15b60ad897a1daa0a561192a7c00
Merge: 62a30ea28c a50f95964f
Author: Austin Bozowski <bozowski@google.com>
Date:   Mon Jan 8 15:15:40 2024 -0800

    Merge branch 'project-chip:master' into idt_dev

commit a9f1816964289dcac3da698efbf52b6937ced6e4
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Jan 4 17:16:38 2024 -0800

    Make analysis text file observation generic

commit 62a30ea28c3cfdf145b940e82352ea2911bba38f
Merge: 7145610504 371756bb6a
Author: Austin Bozowski <bozowski@google.com>
Date:   Thu Jan 4 12:47:25 2024 -0800

    Merge branch 'project-chip:master' into idt_dev

commit 71456105044c2603e4486fde3f21347ef19e1c1b
Merge: 966bd0db5d d2de5d5bcb
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Jan 3 14:54:33 2024 -0800

    Merge branch 'project-chip:master' into idt_dev

commit 2866b3a199597e03f51bf2bef6aee239a3beb62d
Author: Austin Bozowski <bozowski@google.com>
Date:   Wed Dec 20 13:30:55 2023 -0800

    Squashed commit of the following:

    commit 6e18dbb6c0ad8bc8eb647a156ec5f3c90e3ac304
    Author: Austin Bozowski <bozowski@google.com>
    Date:   Wed Dec 20 13:11:21 2023 -0800

        Lint

    commit 183258017c3d47a6a53e562fd997c570a5d115cf
    Merge: 6b8d70aa5d ad98820b71
    Author: Austin Bozowski <bozowski@google.com>
    Date:   Wed Dec 20 12:32:53 2023 -0800

        Merge branch 'master' into idt_feature/play_services_prescriptive1

    commit 6b8d70aa5df2f81669bc3f116a27381ead0b0f03
    Author: Austin Bozowski <bozowski@google.com>
    Date:   Wed Dec 20 12:31:46 2023 -0800

        Make analysis util interface cleaner

    commit ad98820b717f4e0d50c8f5c308790ccbdf02591f
    Author: Yufeng Wang <yufengwang@google.com>
    Date:   Wed Dec 20 11:38:49 2023 -0800

        Return ConnectionFailureException which contains the connection state (#29305)

    commit f7cd2d66150f5b0b21613f80e907f88191a1a753
    Author: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
    Date:   Wed Dec 20 14:26:07 2023 -0500

        Introduce a Status + Cluster Code abstraction (#31121)

        * Introduce a Status + Cluster Code abstraction

        - Existing code always has to split IM status and
          cluster-specific status codes, which causes clumsy
          implementation of clusters (see issue #31120).
        - This PR introduces a value that encapsulates both
          the IM status and cluster-specific status, in an
          easy-to-pass-around abstraction, which can be directly
          used in place of Status.
        - Subsequent PR will implement usage in IM with overloads
          for common cases, such as for AddStatus.

        Issue #31120

        Testing done:
        - Added unit tests
        - Other tests still pass

        * Restyled by clang-format

        * Restyled by gn

        * Address review comments

        * Rename ClusterStatus to ClusterStatusCode

        * Fix build deps

        * Restyled by gn

        ---------

        Co-authored-by: Restyled.io <commits@restyled.io>

    commit 017a9db0d63d2fe2fa3d7140757844e665f76d35
    Author: joonhaengHeo <85541460+joonhaengHeo@users.noreply.github.com>
    Date:   Thu Dec 21 04:13:08 2023 +0900

        Add java empty event struct (#31128)

    commit aaa94059648ef299d21840ffa134e801274135eb
    Author: Karsten Sperling <113487422+ksperling-apple@users.noreply.github.com>
    Date:   Thu Dec 21 07:08:45 2023 +1300

        Simplify CertificationDeclaration EncodeSignerInfo (#31087)

        ... by using ConvertECDSASignatureRawToDER which directly integrates with
        the ASN.1 writer rather than EcdsaRawSignatureToAsn1 from CHIPCryptoPAL.
        Also make the same change in the chip-cert gen-cd command.

    commit 19e202e62f3051f62e720412f439c4777405485d
    Author: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com>
    Date:   Wed Dec 20 06:15:10 2023 -0800

        Media Clusters: Fix for cert test failures (#31047)

        * Fix for cert test failures

        * Fix for channel test cases

    commit ce32d114547172f6aed35a08ff61f7376694030c
    Author: jamesharrow <93921463+jamesharrow@users.noreply.github.com>
    Date:   Wed Dec 20 02:17:27 2023 +0000

        EVSE Delegate callbacks to user application (#30999)

        * Fix #30665 (EVSE)
        - Changed to use amperage_mA, energy_mWh
        - removed max on epoch_s
        - removed access for operate
        - removed side for events

        * Fix #30665 updates to try to get further with ZAP and autogen, but still fails with some parts of regen_all

        * Added ember-compatibility-functions.cpp which was missing.

        * Made all types all lowercase to resolve regen_all issues.

        * Fixed lint issue (trailing whitespace).

        * Fixes #30727 - Added initial EVSE cluster and Example Energy Managament app.

        * Tidied up old comments.

        * Restyled by whitespace

        * Restyled by gn

        * Restyled by prettier-markdown

        * Added copy of files to all-clusters-app linux BUILD.gn and did basic test with chip-tool

        * Fixed lint error (Remove PRId64)

        * Fix for Documentation Build and publish checker.

        * Updated all-clusters-app.zap after merge and regen_all

        * Added Cluster to ESP32 CMakeLists.txt

        * Fixed ESP32 compile error caused by %d

        * Added missing source files to each build variant

        * Restyled by gn

        * Fixed incorrect uint64_t in EnableCharging/EnableDischarging command

        * Fixed more issues seen on different platforms

        * Removed unused mEndpointId

        * Add source files to shell standalone BUILD.gn,  More %d fixes for different platforms

        * Restyled by gn

        * Removed unused mMinimumChargingCurrentLimitFromCommand

        * Removed yet more unused variables

        * Fixed missing semi-colon. How did the other compilers not pick this up?

        * Capitalise function names

        * PR comment - Moved PluginServerInitCallback to sdk. Capitalised more function names in energy-management-app.

        * Restyled by whitespace

        * Fixes #30805 Updated energy-evse-cluster.xml

        * Fixes #30805 zap_regen_all commit.

        * Made Fault Event allow a nullable SessionID

        * Updates based on review (use kMaximumChargeCurrent instead of duplicate #define). Add HwSetVehicleID implementation

        * Added RFID Event support. Removed more unnecessary chip::

        * Added Feature flags, optional commands and optional attributes.

        * Made command handling conditional based on features

        * Added Feature support to all-clusters-app

        * Restyled by clang-format

        * Fix to Darwin compile error - not checking strcmp return

        * Attempt to fix Darwin errors (return after else)

        * Updated based on latest upstream master

        * Removed unnecessary mInstance and used 'this' instead.

        * Regen_all after merge to master.

        * Fix review comment.

        * Ensure Init() returns a failure if there is one. Aligned to mode-base-server.cpp

        * Backed out Read attr check based on features.

        * Fixed EnumerateAcceptedCommands to handle Loop::Break condition.

        * Had missed StartDiagnostic as an optional command in InvokeCommand

        * Removed extra chip:: in attr types.

        * Updated HwSetVehicleID to copy the value from callee

        * Fixed potential buffer overrun in HwSetVehicleID.

        * Fixed simple to address comments raised by Andrei in PR 30857

        * Fixed simple to address comments raised by Andrei in PR 30857

        * Check Delegate is initialized before calling functions.

        * Check Delegate is initialized before calling functions.

        * Added callbacks into Application code

        * Restyled by whitespace

        * Ensured that mVehicleID free's any malloc'd CharSpan in destructor

        * Sync EnergyEvseDelegateImpl.cpp from Example Energy Management

        * Ensured that mVehicleID free's any malloc'd CharSpan in destructor

        * Sync EnergyEvseDelegateImpl.cpp from Example Energy Management

        * Sync'd changes from example energy management app, and commits from #30857 & #30727

        * Added namespace to avoid global namespace error in header file.

        * Re-write of ApplicationInit to handle potential errors

        * Re-write of ApplicationInit to handle potential errors

        * Removed unnecessary void in function decl.

        * Open and saved in ZAP, then regen_all

        * Updated Energy-management-app.zap / .matter after change to general-diagnostics.xml change to MS.

        * Updated Energy-management-app.zap / .matter after change to general-diagnostics.xml change to MS.

        * Restyled by whitespace

        * Fixed types to be signed=true

        * Fixed 31032 - revert removal of side="server". Also turned on Events.

        * PR comment fix - remove Localization Config and Time Format Localization cluster

        * Removed EVSE commands from ZAP to avoid emberAf linker errors since these are handled in the IM Commands handler

        * Regen_all to update energy-management.matter file to remove commands that cause linker errors.

        * Minor changes to align all-clusters and energy-management common.

        * Apply suggestions from code review

        Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

        * Addressed comment and replicated into example energy management copies.

        * Added documentation to EVSE Callbacks as to which struct in the union is used.

        * Added Energy EVSE and Device Energy Management to config-data.yml under CommandHandlerInterfaceOnlyClusters. Then turned on EVSE commands in ZAP.

        ---------

        Co-authored-by: Restyled.io <commits@restyled.io>
        Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

    commit c677109e8acac86cc816497d8447b0a421c6cbd2
    Author: Restyled.io <commits@restyled.io>
    Date:   Wed Dec 20 01:19:10 2023 +0000

        Restyled by isort

    commit 6ae7f608eea27d868ff2791f18ad58f682a9ce57
    Author: Restyled.io <commits@restyled.io>
    Date:   Wed Dec 20 01:19:09 2023 +0000

        Restyled by autopep8

    commit e5b50b285886c810699eb427c952b02d9748c83e
    Author: Austin Bozowski <bozowski@google.com>
    Date:   Tue Dec 19 17:05:10 2023 -0800

        Make cause analysis a generic util

    commit 2a348df474bbf1ecc657fdcd62f00adeb255c69a
    Author: Austin Bozowski <bozowski@google.com>
    Date:   Tue Dec 19 15:53:12 2023 -0800

        Remove unfinished post analysis

    commit dfd130ac0c0f2102ea60776eaec0b1de76389158
    Author: Austin Bozowski <bozowski@google.com>
    Date:   Tue Dec 19 15:39:46 2023 -0800

        Tell user failure detected

    commit 98ff3520799ceb8254b0f3e3330526e1ee44f3df
    Author: Austin Bozowski <bozowski@google.com>
    Date:   Tue Dec 19 14:58:30 2023 -0800

        Bug fix

    commit af751d2ce3e4a306ec7001434d35dd66ed8bda95
    Author: Austin Bozowski <bozowski@google.com>
    Date:   Tue Dec 19 14:33:16 2023 -0800

        Add prescriptive analysis for play services

    commit 13fd61daedf23c8b4bde79adbdc5e137942c3180
    Author: David Rempel <63119829+drempelg@users.noreply.github.com>
    Date:   Tue Dec 19 13:46:20 2023 -0800

        Added just the energy preferences xml. (#30934)

        * Added just the xml and regenerated.  No implementations yet as
        requested.

        * regen

        * Apply suggestions from code review

        Added suggestions for ARRAY vs array

        Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

        * regenerate

        ---------

        Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

    commit 2c8ff779b2ac618b7af95f23bbd46f0c4307698e
    Author: Austin Bozowski <bozowski@google.com>
    Date:   Tue Dec 19 12:53:20 2023 -0800

        Handle err in sub tasks and make post analysis cmd

    commit 5cd1c52cfe6812052fc8ed4751e66a41c32bd92f
    Author: Boris Zbarsky <bzbarsky@apple.com>
    Date:   Tue Dec 19 15:50:25 2023 -0500

        Make sure the MTRDevice lock is held when we touch _weakDelegate. (#31109)

    commit b38d1406c71b0c4f74632067c5149061f6d93c18
    Author: Arkadiusz Bałys <arkadiusz.balys@nordicsemi.no>
    Date:   Tue Dec 19 19:22:50 2023 +0100

        [nrfconnect] Add kconfig for enabling Read Client (#31073)

        To save some FLASH and RAM memory space we can disable Read Client
        functionality in nrfconnect samples.
        This commit adds kconfig to enable or disable Read Client
        in the Interaction Model.

    commit 9643ea470619cd3c8286da2f626cebe52135f707
    Author: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
    Date:   Tue Dec 19 12:54:34 2023 -0500

        [ICD] Add Nonce validation to Check-In protocol and parsing unit tests (#31080)

        * Add Nonce validation and parsing unit tests

        * Add missing comments

        * Remove unused test signature

        * fix comment

        * remove include

        * fix comment

    commit 7f2b39130b5f55bbd103ad7e6c62ab9f3ca6a676
    Author: C Freeman <cecille@google.com>
    Date:   Tue Dec 19 11:40:13 2023 -0500

        TC-ACL-2.2: Implement in python (#31049)

        * TC-ACL-2.2: Implement in python

        Lets us do the all endpoint check in a sane way.

        * flake8

        * Apply suggestions from code review

        Co-authored-by: René Josefsen <69624991+ReneJosefsen@users.noreply.github.com>

        ---------

        Co-authored-by: René Josefsen <69624991+ReneJosefsen@users.noreply.github.com>

    commit cc752a9861ae0e4017fe40056d398d6ddfc99f28
    Author: C Freeman <cecille@google.com>
    Date:   Tue Dec 19 11:31:42 2023 -0500

        Tool to generate a minimal representation of a device. (#30641)

        * DeviceConformance: Factor out conformance checks

        This will let us use conformance as a pre-requisite in other tools.

        * Generates a minimal representation of a device

        This representation gives all the top level optional elements that
        are implemented on the device. Anything that DOES NOT appear in
        this representation is either mandatory or disallowed based on
        the elements represented here.

        * Fix linter

        * Restyled by isort

        * address review comments

        ---------

        Co-authored-by: Restyled.io <commits@restyled.io>

    commit ab113098f1037835d5333798cd68c6add14d8246
    Author: fesseha-eve <88329315+fessehaeve@users.noreply.github.com>
    Date:   Tue Dec 19 15:43:30 2023 +0100

        Update valve configuration and control cluster XML according to latest spec (#30955)

        * update valve configuration and control cluster according to latest spec

        * DefaultOpenDuration is writable and updated device type name to Water Valve

        * moved domain to be the first element

    commit e49c56da5b73d5e0f8a9fc3580762b59cbc83092
    Author: fesseha-eve <88329315+fessehaeve@users.noreply.github.com>
    Date:   Tue Dec 19 11:48:43 2023 +0100

        Update boolean configuration cluster XML according to latest spec (#30950)

        * update boolean configuration cluster according to latest spec

        * rename to boolean state configuration cluster

        * regen after rename to boolean state configuration

        * update device type and cluster names

        * fixed typo

        Co-authored-by: René Josefsen <69624991+ReneJosefsen@users.noreply.github.com>

        * fixed typo, regenerate zap, added Rain Sensor device type

        * update missed cluster names after renaming

        * rename and restyle

        * update domain to Gereral as per https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/8686

        ---------

        Co-authored-by: René Josefsen <69624991+ReneJosefsen@users.noreply.github.com>

    commit 9ba424238824f804e2fbfaa052249dfb1b2bc1bb
    Author: Jaehoon-You <55170115+Jaehoon-You@users.noreply.github.com>
    Date:   Tue Dec 19 19:13:16 2023 +0900

        [Android] virtual-device-app: Remove collapsing layout (#30948)

        * virtual-device-app: Remove collapsing layout

        Signed-off-by: Jaehoon You <jaehoon.you@samsung.com>
        Signed-off-by: Charles Kim <chulspro.kim@samsung.com>

        * virtual-device-app: Cleanup resources

        Signed-off-by: Jaehoon You <jaehoon.you@samsung.com>
        Signed-off-by: Charles Kim <chulspro.kim@samsung.com>

        ---------

        Signed-off-by: Jaehoon You <jaehoon.you@samsung.com>
        Signed-off-by: Charles Kim <chulspro.kim@samsung.com>

    commit 75113fc5876f1d7eb37e2a18eacb389c5ef94381
    Author: Karsten Sperling <113487422+ksperling-apple@users.noreply.github.com>
    Date:   Tue Dec 19 16:14:25 2023 +1300

        ASN.1 null writer check should not bypass reading from TLVReader (#31088)

        ... since it is just intended to be an optimization.

    commit 5786a35453f6c90ba7f4b74a9f722020ccc62140
    Author: Karsten Sperling <113487422+ksperling-apple@users.noreply.github.com>
    Date:   Tue Dec 19 13:41:57 2023 +1300

        Linux: Don't define CHIP_DEVICE_CONFIG_LINUX_DHCPC_CMD by default (#31053)

        ... and compile out the related code if it is not defined.

    commit d63ef5c873d482ed9b4afa878727e9ea7cf96003
    Author: jamesharrow <93921463+jamesharrow@users.noreply.github.com>
    Date:   Mon Dec 18 20:09:55 2023 +0000

        EVSE and Device Energy Management XML should use new base energy reporting types (and other minor fixes) (#30701)

        * Fix #30665 (EVSE)
        - Changed to use amperage_mA, energy_mWh
        - removed max on epoch_s
        - removed access for operate
        - removed side for events

        * Fix #30665 updates to try to get further with ZAP and autogen, but still fails with some parts of regen_all

        * Added ember-compatibility-functions.cpp which was missing.

        * Made all types all lowercase to resolve regen_all issues.

        * Fixed lint issue (trailing whitespace).

        * Aligned EVSE XML to same state as PR#30857 (includes SessionID being Nullable etc and in Fault Event).

        * Updated Device Energy Management XML to use power_mw, energy_mwh per spec definition.

        * Updated controller-clusters.zap

        * regen_all.py

        * Restyled by whitespace

        * Fixed types to be signed=true

        * Fixed 31032 - revert removal of side="server".

        * regen_all.py

        * Change to cause restyled to re-run after failure. :(

        * Revert "Change to cause restyled to re-run after failure. :("

        This reverts commit b515c33e8186018c2f437a8d91a0cf80a028467e.

        ---------

        Co-authored-by: Restyled.io <commits@restyled.io>

    commit 342e33824d4d70cf896456d3ae20bb641cc577e3
    Author: Yufeng Wang <yufengwang@google.com>
    Date:   Mon Dec 18 10:22:47 2023 -0800

        Implement cluster subscription API (#31057)

    commit 9310a374cb3d728245b6b99004f3f3727a5ed565
    Author: William <hicklin@users.noreply.github.com>
    Date:   Mon Dec 18 13:12:45 2023 +0000

        Update rvc example to handel new pause compatible states (#30963)

        * Updated the RVC example app to appropriatly handel the RvcOpState Pasue and Resume commands for the new pause and resume compatible states.

        * Updated the RVC example app's state machine diagram.

        * Restyled by clang-format

        * Added some clarifying comments to the RvcDevice pause and resume commands handle methods. Renamed variable for clarity. Removed unnecessary temp hold of pause state.

        * Restyled by clang-format

        * Changed the naming to note the state that was paused rather than the state that we will resume to as we cannot know the state that the device will resume to when the pause command is handled.

        * Clarified comments following reviews.

        * Modified the resume callback logic to be more concise.

        * Restyled by clang-format

        ---------

        Co-authored-by: Restyled.io <commits@restyled.io>
        Co-authored-by: chrismapp <42716253+chrismapp@users.noreply.github.com>

    commit 62606d283ee82437c555dc7489a9a9ea36a826c8
    Author: jamesharrow <93921463+jamesharrow@users.noreply.github.com>
    Date:   Mon Dec 18 12:48:23 2023 +0000

        [EVSE] add evse cluster and examples energy management app (#30793)

        * Fix #30665 (EVSE)
        - Changed to use amperage_mA, energy_mWh
        - removed max on epoch_s
        - removed access for operate
        - removed side for events

        * Fix #30665 updates to try to get further with ZAP and autogen, but still fails with some parts of regen_all

        * Added ember-compatibility-functions.cpp which was missing.

        * Made all types all lowercase to resolve regen_all issues.

        * Fixed lint issue (trailing whitespace).

        * Fixes #30727 - Added initial EVSE cluster and Example Energy Managament app.

        * Tidied up old comments.

        * Restyled by whitespace

        * Restyled by gn

        * Restyled by prettier-markdown

        * Added copy of files to all-clusters-app linux BUILD.gn and did basic test with chip-tool

        * Fixed lint error (Remove PRId64)

        * Fix for Documentation Build and publish checker.

        * Updated all-clusters-app.zap after merge and regen_all

        * Added Cluster to ESP32 CMakeLists.txt

        * Fixed ESP32 compile error caused by %d

        * Added missing source files to each build variant

        * Restyled by gn

        * Fixed incorrect uint64_t in EnableCharging/EnableDischarging command

        * Fixed more issues seen on different platforms

        * Removed unused mEndpointId

        * Add source files to shell standalone BUILD.gn,  More %d fixes for different platforms

        * Restyled by gn

        * Removed unused mMinimumChargingCurrentLimitFromCommand

        * Removed yet more unused variables

        * Fixed missing semi-colon. How did the other compilers not pick this up?

        * Capitalise function names

        * PR comment - Moved PluginServerInitCallback to sdk. Capitalised more function names in energy-management-app.

        * Restyled by whitespace

        * Fixes #30805 Updated energy-evse-cluster.xml

        * Fixes #30805 zap_regen_all commit.

        * Made Fault Event allow a nullable SessionID

        * Updates based on review (use kMaximumChargeCurrent instead of duplicate #define). Add HwSetVehicleID implementation

        * Added RFID Event support. Removed more unnecessary chip::

        * Added Feature flags, optional commands and optional attributes.

        * Made command handling conditional based on features

        * Added Feature support to all-clusters-app

        * Restyled by clang-format

        * Fix to Darwin compile error - not checking strcmp return

        * Attempt to fix Darwin errors (return after else)

        * Updated based on latest upstream master

        * Removed unnecessary mInstance and used 'this' instead.

        * Regen_all after merge to master.

        * Fix review comment.

        * Ensure Init() returns a failure if there is one. Aligned to mode-base-server.cpp

        * Backed out Read attr check based on features.

        * Fixed EnumerateAcceptedCommands to handle Loop::Break condition.

        * Had missed StartDiagnostic as an optional command in InvokeCommand

        * Removed extra chip:: in attr types.

        * Updated HwSetVehicleID to copy the value from callee

        * Fixed potential buffer overrun in HwSetVehicleID.

        * Fixed simple to address comments raised by Andrei in PR 30857

        * Check Delegate is initialized before calling functions.

        * Ensured that mVehicleID free's any malloc'd CharSpan in destructor

        * Sync EnergyEvseDelegateImpl.cpp from Example Energy Management

        * Re-write of ApplicationInit to handle potential errors

        * Open and saved in ZAP, then regen_all

        * Updated Energy-management-app.zap / .matter after change to general-diagnostics.xml change to MS.

        * Fixed types to be signed=true

        * Fixed 31032 - revert removal of side="server". Also turned on Events.

        * PR comment fix - remove Localization Config and Time Format Localization cluster

        ---------

        Co-authored-by: Restyled.io <commits@restyled.io>

    commit 7cbac9130d2b10d6bfdba873129dfbffa294cf8d
    Author: Michael Spang <spang@google.com>
    Date:   Sun Dec 17 22:36:28 2023 -0500

        Remove java_build_test from multiarch build (#31048)

        This test doesn't work with multiple toolchains since it assumes an
        output directory.

    commit 44e1a70818450a6115bae9d7ef9bfaf60d2516a7
    Author: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
    Date:   Sun Dec 17 22:35:47 2023 -0500

        Fix TestPlatformMgr crash (#31052)

        - TestPlatformMgr did not set a CommissionableDataProvider.
        - Recent code changes make that test hit codepaths that try
          to setup BLE advertisement on Linux platform when default-built.
        - This PR adds a CommissionableDataProvider instance for the whole
          test with default test values. Tests now pass.

        Fixes #30640

    commit b58488e59fdbf9db93794b6fc97ad101abded960
    Author: Michael Spang <spang@google.com>
    Date:   Sun Dec 17 10:49:30 2023 -0500

        Make wholesale replacement of lwIP more straightforward (#31025)

        * Make wholesale replacement of lwIP more straightforward

        Instead of everyone directly adjusting the definintions in src/lwip,
        which only works in-tree, clean up the dependencies so that overriding
        lwip_root works cleanly (ie, without introducing dependencies on
        $chip_root/src/lwip).

        See docs in third_party/lwip/BUILD.gn

        * Fix use of vendored lwip from EFR32 builds

        * Fix potential .o file naming conflicts

        If multiple libraries compile src/lwip/freertos/sys_arch.c, this causes
        problems from having the same .o file name. Use different library names
        to make sure this does not happen.

        * Fixups for genio-lighting-app build

        * Clarify ways to set lwip_root

        * Restyled by gn

        ---------

        Co-authored-by: Restyled.io <commits@restyled.io>

    commit ea5224111941a28f34af2bd958bac6f7900a55f8
    Author: C Freeman <cecille@google.com>
    Date:   Sun Dec 17 10:48:44 2023 -0500

        TC-IDM-1.2: Use random discriminator (#31046)

    commit cdf984ea3828982d5776b77327a3658ee6cf15c9
    Author: fengdx4 <131833628+fengdx4@users.noreply.github.com>
    Date:   Sun Dec 17 17:07:47 2023 +0800

        [Feature]Microwave oven control cluster implementation (#30235)

        * Microwave oven control cluster implementation

        * Restyled by whitespace

        * Restyled by clang-format

        * updated SDK code of MicrowaveOvenControl for checking all the input values

        * Restyled by clang-format

        * fix build err

        * 1. modified SDK and app layer for MicrowaveOvenControl Cluster to avoid using Attribute accessor; 2. add microwave oven device app

        * revised device classification ID in examples/microwave-oven-app/linux/include/CHIPProjectAppConfig.h

        * updated all-cluster-app for returning original

        * updated zap&matter files for adding new updates

        * updated the commented code for Microwave Oven Control cluster

        * Restyled by whitespace

        * Restyled by clang-format

        * Restyled by prettier-json

        * revised copyright and README info

        * removed 'feature map' in the zcl*.json

        * Restyled by whitespace

        * Restyled by clang-format

        * Restyled by prettier-json

        * Restyled by prettier-markdown

        * updated SDK code after reviewed

        * Restyled by whitespace

        * Restyled by clang-format

        * updated zap configuration for BASIC

        * updated microwave oven control SDK for typo

        * updated restyled

        * Restyled by whitespace

        * Restyled by clang-format

        * updated Application for microwave oven device

        * Restyled by whitespace

        * Restyled by clang-format

        * revised some reviewed typo

        * Restyled by clang-format

        * Restyled by gn

        * updated App code after reviewed

        * Restyled by whitespace

        * Restyled by clang-format

        * update some comment

        * Restyled by whitespace

        * Restyled by gn

        * recover examples/build_overrides/pigweed_environment.gni

        * Restyled by gn

        * fix typos and add unique ptr to stdfunction

        * update add-more-time command relative functions name

        * Restyled by whitespace

        * Restyled by clang-format

        * regen microwave-oven-app.matter

        * Restyled by clang-format

        * update add-more-time command function name

        * Restyled by clang-format

        * removed mode code

        * fix typo in main.cpp

        * update microwave oven device app and sdk

        * compiling app

        * compling sdk

        * compiling app, sdk

        * update Microwave Oven Application and SDK code after reviewed

        * Restyled by whitespace

        * Restyled by clang-format

        * update MicrowaveOven App after reviewed

        * Restyled by whitespace

        * Restyled by clang-format

        * updated MicrowaveOvenControl

        * Restyled by whitespace

        * fix all_targets_linux_x64.txt

        * update microwave oven app for program entry

        * Restyled by whitespace

        * Restyled by clang-format

        * move all private after public for microwave-oven-device.h

        * Restyled by clang-format

        * update microwave oven app after reviewed

        * Restyled by whitespace

        * Restyled by clang-format

        * update microwave oven mode after reviewed

        * Restyled by clang-format

        * update microwave-oven-app.matter

        * regen ZAP

        * add api for ModeBase and updated MicrowaveOvenControl

        * Restyled by whitespace

        * Restyled by clang-format

        * update code after reviewed

        * regen ZAP

        * Restyled by clang-format

        ---------

        Co-authored-by: mideayanghui <yanghui65@midea.com>
        Co-authored-by: Restyled.io <commits@restyled.io>
        Co-authored-by: ex_liangpy4 <ex_liangpy4@partner.midea.com>

    commit 0a5f3d38ec4169d1c005d5c4ecf13ec56ae29eac
    Author: Michael Spang <spang@google.com>
    Date:   Fri Dec 15 17:32:44 2023 -0500

        Remove dead !HAVE_LWIP_UDP_BIND_NETIF configuration (#31045)

        * Remove dead !HAVE_LWIP_UDP_BIND_NETIF configuration

        This define came in with the initial import, but we never provided any
        way to turn it off. Remove that case as dead code.

        * Remove LWIP_NO_STDINT_H on Android

        Android doesn't use lwIP, and the NDK has stdint.h, so this seems pretty
        strange. Remove it.

    commit 23add0b62a1ecbe189db42a69537dca1c883f9da
    Author: Boris Zbarsky <bzbarsky@apple.com>
    Date:   Fri Dec 15 17:06:35 2023 -0500

        Mark OperationalState as no longer provisional on Darwin. (#30937)

        Also explicitly marks ElectricalEnergyMeasurement as provisional.

    commit 93be827736fd7301cf94964d8014dff6ff73245b
    Author: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
    Date:   Fri Dec 15 17:00:31 2023 -0500

        Clean-up time conversions on the way to fix #30990 (#31021)

        * Clean-up time conversions locations

        - Test conversions in Time Sync cluster were not in a unit-testable
          location.
        - TestTimeUtils was not using nl-unit-test
        - Time sync cluster server build rules were missing dependencies
        - Documentation for many time conversion methods was not accurate
        - `secondsToMilliseconds` did not match coding style
        - Cleaned-up cut and paste errors in some adjacent tests.

        Issue #30990

        Testing done:
        - Unit tests and integration tests still pass.
        - Started tests for edge conditions (which found #30990)

        * Restyled by clang-format

        * Add backwards compatibility

        ---------

        Co-authored-by: tennessee.carmelveilleux@gmail.com <tennessee@google.com>
        Co-authored-by: Restyled.io <commits@restyled.io>

    commit 96970dffd88a99c2d79f18e22642c31c84415b2c
    Author: yunhanw-google <yunhanw@google.com>
    Date:   Fri Dec 15 13:59:31 2023 -0800

        Improve ICDClientStorage (#30931)

    commit da2dfe0bfa7e0c3bec9fa53b506c0dcbe10bfab2
    Author: Boris Zbarsky <bzbarsky@apple.com>
    Date:   Fri Dec 15 16:58:57 2023 -0500

        Make the logic for whether a session matches an eviction hint more readable. (#30938)

        Addresses https://github.com/project-chip/connectedhomeip/pull/30806#discussion_r1415764912

    commit d405b70b5ed0c9347f5360224b2f6f47f7627df3
    Author: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
    Date:   Fri Dec 15 15:45:54 2023 -0500

        [ICD] Add unit tests to validate Check-In message generation (#31040)

        * Add Check-In message test vectors

        * Add nonce generation and payload size tests

        * Update comments

        * Move nonce generation function out of the class

        * Refactor test to use public generation APIs

        * Move function to where it was

        * Add missing test comments

    commit 35455fa577cf114b68016660118e3d408fca253c
    Author: C Freeman <cecille@google.com>
    Date:   Fri Dec 15 15:09:46 2023 -0500

        TC-CGEN-2.4: Use random discriminator (#31044)

    commit 6c6fe0a76b1b4a79f8dbf1102324d7bdf74d9e80
    Author: jamesharrow <93921463+jamesharrow@users.noreply.github.com>
    Date:   Fri Dec 15 19:47:43 2023 +0000

        Add EnergyEvse to all-clusters-app (#30857)

        * Fix #30665 (EVSE)
        - Changed to use amperage_mA, energy_mWh
        - removed max on epoch_s
        - removed access for operate
        - removed side for events

        * Fix #30665 updates to try to get further with ZAP and autogen, but still fails with some parts of regen_all

        * Added ember-compatibility-functions.cpp which was missing.

        * Made all types all lowercase to resolve regen_all issues.

        * Fixed lint issue (trailing whitespace).

        * Fixes #30727 - Added initial EVSE cluster and Example Energy Managament app.

        * Tidied up old comments.

        * Restyled by whitespace

        * Restyled by gn

        * Restyled by prettier-markdown

        * Added copy of files to all-clusters-app linux BUILD.gn and did basic test with chip-tool

        * Fixed lint error (Remove PRId64)

        * Fix for Documentation Build and publish checker.

        * Updated all-clusters-app.zap after merge and regen_all

        * Added Cluster to ESP32 CMakeLists.txt

        * Fixed ESP32 compile error caused by %d

        * Added missing source files to each build variant

        * Restyled by gn

        * Fixed incorrect uint64_t in EnableCharging/EnableDischarging command

        * Fixed more issues seen on different platforms

        * Removed unused mEndpointId

        * Add source files to shell standalone BUILD.gn,  More %d fixes for different platforms

        * Restyled by gn

        * Removed unused mMinimumChargingCurrentLimitFromCommand

        * Removed yet more unused variables

        * Fixed missing semi-colon. How did the other compilers not pick this up?

        * Capitalise function names

        * PR comment - Moved PluginServerInitCallback to sdk. Capitalised more function names in energy-management-app.

        * Restyled by whitespace

        * Fixes #30805 Updated energy-evse-cluster.xml

        * Fixes #30805 zap_regen_all commit.

        * Removed energy-management-app from this branch to make PR smaller to review

        * Changing something to force a rebuild once I turned off backwards compatibility check

        * Update examples/all-clusters-app/all-clusters-common/include/EnergyEvseDelegateImpl.h

        Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

        * Made Fault Event allow a nullable SessionID

        * Updates based on review (use kMaximumChargeCurrent instead of duplicate #define). Add HwSetVehicleID implementation

        * Added RFID Event support. Removed more unnecessary chip::

        * Added Feature flags, optional commands and optional attributes.

        * Made command handling conditional based on features

        * Added Feature support to all-clusters-app

        * Restyled by clang-format

        * Restyled by clang-format

        * Fix to Darwin compile error - not checking strcmp return

        * Fix to Darwin compile error - not checking strcmp return

        * Attempt to fix Darwin errors (return after else)

        * Attempt to fix Darwin errors (return after else)

        * Merged to upstream master

        * Updated based on latest upstream master

        * Removed unnecessary mInstance and used 'this' instead.

        * Regen_all after merge to master.

        * Fix review comment.

        * Ensure Init() returns a failure if there is one. Aligned to mode-base-server.cpp

        * Backed out Read attr check based on features.

        * Fixed EnumerateAcceptedCommands to handle Loop::Break condition.

        * Had missed StartDiagnostic as an optional command in InvokeCommand

        * Removed extra chip:: in attr types.

        * Updated HwSetVehicleID to copy the value from callee

        * Fixed potential buffer overrun in HwSetVehicleID.

        * Ensured that mVehicleID free's any malloc'd CharSpan in destructor

        * Sync EnergyEvseDelegateImpl.cpp from Example Energy Management

        ---------

        Co-authored-by: Restyled.io <commits@restyled.io>
        Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

    commit 964c8550f8043078021f3ac042f53a0797fc832e
    Author: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com>
    Date:   Fri Dec 15 15:16:23 2023 -0300

        Add lit-icd app to chip-cert-bins image (#31036)

    commit 221e466510600543fee1d9fb70f270022e37866e
    Author: yunhanw-google <yunhanw@google.com>
    Date:   Thu Dec 14 20:05:23 2023 -0800

        [ICD]add hmac support in icd client storage (#30939)

        * add hmac support in icd client storage

        * address comment

        * address comments

        * add missing change

        * Update examples/chip-tool/commands/icd/ICDCommand.cpp

        Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>

        * Update src/app/icd/client/DefaultICDClientStorage.cpp

        Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>

        * Restyled by clang-format

        ---------

        Co-authored-by: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
        Co-authored-by: Restyled.io <commits@restyled.io>

    commit 73b8588e4529edf30cd78704e138fe51a2052008
    Author: Vatsal Ghelani <152916324+vatsalghelani-csa@users.noreply.github.com>
    Date:   Thu Dec 14 21:57:18 2023 -0500

        Upgrade labeler config to v5 from v4 (#31024)

        * Update labeler.yaml

        * Update labeler.yml -> Updating config file to solve for the error after the merge

        Error Link: https://github.com/project-chip/connectedhomeip/actions/runs/7213100260/job/19652200726?pr=31009

        Error: found unexpected type for label 'scripts' (should be array of config options)

        * Update labeler.yaml -> Changing workflow to the major version v5 instead of v5.0.0

        Changing workflow to the major version v5 instead of v5.0.0

    commit 1f3bcbc955522430151d3127b5dbc7140b7a2366
    Author: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
    Date:   Thu Dec 14 16:52:18 2023 -0500

        Fix TimeSnapshotResponse command types/names to match spec updates (#31018)

        * Fix General Diagnostics XML to match spec

        See https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/8673

        * Regen zap

        ---------

        Co-authored-by: tennessee.carmelveilleux@gmail.com <tennessee@google.com>

    commit ff5b64dc3f81348408b3dd5e1afa66726ec1ee42
    Author: mkardous-silabs <84793247+mkardous-silabs@users.noreply.github.com>
    Date:   Thu Dec 14 16:36:33 2023 -0500

        [ICD] Add Hmac Key handle to ICDCheckInSender to support PSA backend (#30926)

        * refactor CheckInMessage impl

        * finish ICD Check-In cleanup

        * Restyled by whitespace

        * Restyled by clang-format

        * Remove unused includes

        * Apply suggestions from code review

        Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
        Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>

        * update test comments

        * Restyle ICDCheckInSender

        * Update error and associated comments

        * refactor Check-In message impl

        * rename gargantua to veryLarge

        * add missing include

        * Add buffer writer when encoding ActiveModeThreshold

        * Refactor subspan logic to use a cusorIndex

        * Apply suggestions from code review

        Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

        * Fix function comments
        rename min payload size

        * Update src/app/icd/ICDCheckInSender.cpp

        Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>

        ---------

        Co-authored-by: Restyled.io <commits@restyled.io>
        Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
        Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>

    commit 5e6db9c9e30adc0240e214f1aeb7544a8ed3178b
    Author: Rob Bultman <rob.Bultman@gmail.com>
    Date:   Thu Dec 14 15:12:19 2023 -0500

        Fix typo in XML for Content Launcher cluster (#31015)

        * Fix typo

        * Committing files from zap regen

    commit a173840a261769581e8428c3fd8140110649ffe6
    Author: Terence Hampson <thampson@google.com>
    Date:   Thu Dec 14 14:53:36 2023 -0500

        Remove space character from python test filename (#31013)

    commit d8a8a8a1d103f1092629667082f828668a65c374
    Author: Andrei Litvin <andy314@gmail.com>
    Date:   Thu Dec 14 13:38:44 2023 -0500

        Revert "Upgrade labeler config to v5 from v4 (#30996)" (#31016)

        This reverts commit eaf3aa3c2bd2f3d936aca27952e4416b3186c038.

        Co-authored-by: Andrei Litvin <andreilitvin@google.com>

    commit eaf3aa3c2bd2f3d936aca27952e4416b3186c038
    Author: Vatsal Ghelani <152916324+vatsalghelani-csa@users.noreply.github.com>
    Date:   Thu Dec 14 13:32:00 2023 -0500

        Upgrade labeler config to v5 from v4 (#30996)

        * Update labeler.yaml -> Added the version upgrade to v5.0.0 from v4

        Added the version upgrade to v5.0.0 from v4

        * Update labeler.yml -> Added correction syntax for configuring file

        * Update labeler.yml -> Correcting the syntax to configure file

        Correcting the syntax to configure file

        * Update labeler.yml -> Correcting the syntax to configure file

        Correcting the syntax to configure file

        * Update labeler.yml -> Correcting the syntax to configure file

        Correcting the syntax to configure file

        * Update labeler.yaml -> Changing workflow to the major version v5 instead of v5.0.0

        Changing workflow to the major version v5 instead of v5.0.0

    commit 7f43a9327ebd538ad35d01f4277afbbbab4b9aaf
    Author: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com>
    Date:   Thu Dec 14 13:29:11 2023 -0500

        Fix typo in many tests (#31014)

        Co-authored-by: tennessee.carmelveilleux@gmail.com <tennessee@google.com>

    commit 53daf2dfff3719cc0e49a0645f04493ca99c9a4f
    Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Date:   Thu Dec 14 12:24:17 2023 -0500

        Bump third_party/openthread/repo from `b78b71b` to `266a97b` (#31011)

        Bumps [third_party/openthread/repo](https://github.com/openthread/openthread) from `b78b71b` to `266a97b`.
        - [Release notes](https://github.com/openthread/openthread/releases)
        - [Commits](https://github.com/openthread/openthread/compare/b78b71b537ea13419543d14eacbf164b15af6c99...266a97b80ab7ce7fea7fc5b0200fdbec0537f40d)

        ---
        updated-dependencies:
        - dependency-name: third_party/openthread/repo
          dependency-type: direct:production
        ...

        Signed-off-by: dependabot[bot] <support@github.com>
        Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

    commit 162e93961c0ae50f3665157234dcecbf87b6e047
    Author: Terence Hampson <thampson@google.com>
    Date:   Thu Dec 14 12:08:26 2023 -0500

        Prevent TLVWrite from possibly performing buffer overrun if trying to reserve (#30714)

        * Prevent TLVWrite from possibly performing buffer overrun when calling reserve

        * Quick cleanup

        * Address PR Comments

        * Address CI comments

        * Address CI comments

        * Small fix

        * Address PR Comment

        * Missing file save

        * Fix CI

    commit 717376976abf7fbaf5f7542de4ba4140e6621c1e
    Author: Timothy Maes <timothy.maes@qorvo.com>
    Date:   Thu Dec 14 16:27:35 2023 +0100

        [QPG] Update OpenThreadConfig.h for undef flags (#31008)

        Adding 2 undefined Thread flags: OPENTHREAD_CONFIG_DTLS_ENABLE
        OPENTHREAD_CONFIG_BLE_TCAT_ENABLE
        Unblocks PR #30919

    commit 02683eee53ce584d258bbfe5edc0868e0844e48e
    Author: Yufeng Wang <yufengwang@google.com>
    Date:   Thu Dec 14 06:48:01 2023 -0800

        Support timeout null instead of requiring ZERO for no timeout (#30967)

        * Support timeout null instead of requiring ZERO for no timeout

        * Address review comments

    commit b0a7f9ce852214527ecdd04819fd94cc87375f80
    Author: Alex Tsitsiura <s07641069@gmail.com>
    Date:   Thu Dec 14 16:36:40 2023 +0200

        [Telink] Add NFC Tag support (#31005)

        * add draft nfc tag implementation

        * add nfc tag implementation

        * fix nfc building issue

        * Restyled by clang-format

        ---------

        Co-authored-by: Dmytro Kashkarov <ur6lal@gmail.com>
        Co-authored-by: Restyled.io <commits@restyled.io>

    commit 51fa463f44e3e87c17ca1172bdf6ba875650843d
    Author: Vincent Coubard <vincent.coubard@arm.com>
    Date:   Thu Dec 14 14:34:59 2023 +0000

        OIS: Restrict runtime test to manual trigger (#31003)

        Open IoT SDK tests are too flaky in the public environment (Github
        Runner + Public FVP) which impedes Matter development.

        Until the environment is improved, the runtime test step is restricted
        to manual launch of the open IoT SDK workflow.

        Signed-off-by: Vincent Coubard <vincent.coubard@arm.com>

    commit 7960dbdfff87939cd655d96752ef7cc511a9000e
    Author: Stefan Agner <stefan@agner.ch>
    Date:   Thu Dec 14 13:33:05 2023 +0100

        [Python] Support commissioning with code on network only (#31000)

        * [Python] Support commissioning with code on network only

        Add an additional parameter to support commissioning on network only.
        This is useful when a manual pairing code is given and we know the
        device is on the network already.

        * Use consistent casing for newly added parameter

    commit 4fe0f8ddc915c1965e63b17c7d91db5ac85e55ad
    Author: chrisdecenzo <61757564+chrisdecenzo@users.noreply.github.com>
    Date:   Thu Dec 14 03:47:40 2023 -0800

        Fix…
  • Loading branch information
aBozowski committed Feb 6, 2024
1 parent 0a6db87 commit 4a97230
Show file tree
Hide file tree
Showing 107 changed files with 3,329 additions and 1,217 deletions.
2 changes: 2 additions & 0 deletions src/tools/interop/idt/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ pycache/
venv/
.zip
BUILD
BUILD_LOG.txt
prober_urls.txt
236 changes: 153 additions & 83 deletions src/tools/interop/idt/README.md

Large diffs are not rendered by default.

33 changes: 30 additions & 3 deletions src/tools/interop/idt/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,36 @@
# limitations under the License.
#

import os
import sys

import psutil

from idt import InteropDebuggingTool
from utils.host_platform import verify_py_version
from utils.host import current_platform
from utils.log import get_logger
from utils.shell import Bash

logger = get_logger(__file__)
dirty_cleanup = True

if __name__ == "__main__":
verify_py_version()
InteropDebuggingTool()
try:
current_platform.verify_py_version()
InteropDebuggingTool()
dirty_cleanup = False
finally:
logger.info("Checking for stray child processes")
psutil_proc = psutil.Process(os.getpid())
found = False
for child_proc in psutil_proc.children(recursive=True):
found = True
command_short = Bash("").get_current_command_for_pid(child_proc.pid)
command_full = Bash("").get_current_command_for_pid_full(child_proc.pid)
logger.error(f"PID: {child_proc.pid} \nCOMMAND: {command_short}\n{command_full}")
if found:
logger.error("Stray processes detected, you might want to clean these up!")
else:
logger.info("No stray processes detected!")
if dirty_cleanup and not sys.argv[len(sys.argv)-1] == "-h":
logger.critical("Crash detected! Clean up any stray processes listed above!!!")

This file was deleted.

14 changes: 0 additions & 14 deletions src/tools/interop/idt/capture/platform/android/streams/__init__.py

This file was deleted.

This file was deleted.

44 changes: 40 additions & 4 deletions src/tools/interop/idt/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,45 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#

import logging

enable_color = True
log_level = logging.INFO
py_major_version = 3
py_minor_version = 11
from res.splash import splash as _splash

IDT_VERSION = "1.0.0"
DEBUG = False
ENABLE_COLOR = True
LOG_LEVEL = logging.DEBUG if DEBUG else logging.INFO
PY_MAJOR_VERSION = 3
PY_MINOR_VERSION = 11
SPLASH = _splash
# TODO: Model this differently, e.g. dataclass: help, link, reason etc.?
# TODO: Script to autodetect dependencies used in the repo to make maintaining this easier
HOST_DEPENDENCIES = {
"ALL": {
"adb":
"adb is required for interacting with Android devices: "
"https://developer.android.com/studio/command-line/adb",
"tcpdump":
"tcpdump is required for taking host packet captures. It should be available on all systems.",
"git":
"git is required for downloading build tools. It should already be present on a system using this tool.",
"tee":
"tee is required to write and view logs at the same time. It should be available on all systems."
},
"LINUX": {
"airmon-ng":
"The aircrack suite is used to manage processes and interfaces for monitor mode pcaps"
"https://www.aircrack-ng.org/doku.php?id=install_aircrack#installing_pre-compiled_binaries",
},
"MAC": {
"airport":
"Airport is required for taking monitor mode packet captures on the idt host."
"It is likely on your system but not on your path."
"Try looking for the binary in a path like this"
"/System/Library/PrivateFrameworks/Apple80211.framework/Versions/A/Resources/airport"
"and add it to your path!",
# "brew":
# "brew is required for installing otbrrcp build tools on MacOS: https://brew.sh/",
},
}
Loading

0 comments on commit 4a97230

Please sign in to comment.