Skip to content

Commit

Permalink
[NXP] Add ICD _SetPollingInterval and set minimum ActiveModeThreshold…
Browse files Browse the repository at this point in the history
… to 5 seconds (#33875)

* [NXP][common] The minimum ActiveModeThreshold value for a LIT ICD is 5 seconds

During initialization, the app would stuck in an assert if the app was configured
as a LIT ICD:

VerifyOrDieWithMsg(ICDConfigurationData::GetInstance().GetMinLitActiveModeThreshold() <=
                   ICDConfigurationData::GetInstance().GetActiveModeThreshold(),
                   AppServer, "The minimum ActiveModeThreshold value for a LIT ICD is 5 seconds.");

Setting the default value of nxp_active_mode_threshold_ms to 5000ms fixes the issue.

Signed-off-by: marius-alex-tache <marius.tache@nxp.com>

* [NXP][platform][common] Add the _SetPollingInterval for Wi-Fi SIT ICDM function

Signed-off-by: Chin-Ran Lo <nxf57500@lsv051039.swis.nl-cdc01.nxp.com>

---------

Signed-off-by: marius-alex-tache <marius.tache@nxp.com>
Signed-off-by: Chin-Ran Lo <nxf57500@lsv051039.swis.nl-cdc01.nxp.com>
Co-authored-by: marius-alex-tache <marius.tache@nxp.com>
Co-authored-by: Chin-Ran Lo <nxf57500@lsv051039.swis.nl-cdc01.nxp.com>
  • Loading branch information
3 people authored Jun 17, 2024
1 parent ba640aa commit 5217353
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
10 changes: 10 additions & 0 deletions src/platform/nxp/common/ConnectivityManagerImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,16 @@ CHIP_ERROR ConnectivityManagerImpl::_DisconnectNetwork(void)

return err;
}

#if CHIP_CONFIG_ENABLE_ICD_SERVER
CHIP_ERROR ConnectivityManagerImpl::_SetPollingInterval(System::Clock::Milliseconds32 pollingInterval)
{
/*
* ToDo: Call API to put device into sleep
*/
return CHIP_NO_ERROR;
}
#endif // CHIP_CONFIG_ENABLE_ICD_SERVER
#endif

} // namespace DeviceLayer
Expand Down
3 changes: 3 additions & 0 deletions src/platform/nxp/common/ConnectivityManagerImpl.h
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ class ConnectivityManagerImpl final : public ConnectivityManager,

#if CHIP_DEVICE_CONFIG_ENABLE_WPA
void StartWiFiManagement();
#if CHIP_CONFIG_ENABLE_ICD_SERVER
CHIP_ERROR _SetPollingInterval(System::Clock::Milliseconds32 pollingInterval);
#endif // CHIP_CONFIG_ENABLE_ICD_SERVER
#if CHIP_ENABLE_OPENTHREAD
Inet::InterfaceId GetExternalInterface();
Inet::InterfaceId GetThreadInterface();
Expand Down
2 changes: 1 addition & 1 deletion third_party/nxp/nxp_sdk.gni
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ declare_args() {

nxp_idle_mode_duration_s = 600 # 10min Idle Mode Interval
nxp_active_mode_duration_ms = 10000 # 10s Active Mode Interval
nxp_active_mode_threshold_ms = 1000 # 1s Active Mode Threshold
nxp_active_mode_threshold_ms = 5000 # 5s Active Mode Threshold
nxp_icd_supported_clients_per_fabric = 2 # 2 registration slots per fabric
}

Expand Down

0 comments on commit 5217353

Please sign in to comment.