Address final comments from Andrei

project-chip · Jul 25, 2024 · 6dc3eaf · 6dc3eaf
1 parent 915db4f
commit 6dc3eaf
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/examples/energy-management-app/energy-management-common/include/ChargingTargetsMemMgr.h b/examples/energy-management-app/energy-management-common/include/ChargingTargetsMemMgr.h
@@ -113,6 +113,9 @@ class ChargingTargetsMemMgr
     /**
      * @brief Called to allocate and copy the chargingTargets into the current day schedule as set
      *        set by PrepareDaySchedule().
+     *        If an attempt is made to add more than kEvseTargetsMaxTargetsPerDay chargingTargets
+     *        for the current day schedule, then the chargingTarget is not added and an error message
+     *        is printed.
      *
      * @param chargingTargets  - The chargingTargets to add into the current day schedule
      */

diff --git a/examples/energy-management-app/energy-management-common/src/ChargingTargetsMemMgr.cpp b/examples/energy-management-app/energy-management-common/src/ChargingTargetsMemMgr.cpp
@@ -71,6 +71,10 @@ void ChargingTargetsMemMgr::AddChargingTarget(const EnergyEvse::Structs::Chargin
     {
         mDailyChargingTargets[mNumDailyChargingTargets++] = chargingTarget;
     }
+    else
+    {
+        ChipLogError(AppServer, "AddChargingTarget: trying to add too many chargingTargets");
+    }
 }
 
 EnergyEvse::Structs::ChargingTargetStruct::Type * ChargingTargetsMemMgr::GetChargingTargets() const
-Original file line number
+Diff line change
@@ Expand Up @@
         {
             mDailyChargingTargets[mNumDailyChargingTargets++] = chargingTarget;
         }
+        else
+        {
+            ChipLogError(AppServer, "AddChargingTarget: trying to add too many chargingTargets");
+        }
     }
     EnergyEvse::Structs::ChargingTargetStruct::Type * ChargingTargetsMemMgr::GetChargingTargets() const
@@ Expand Down @@