Failure handling and fixed typo

project-chip · Jun 28, 2022 · 75f1528 · 75f1528
1 parent 3f4303d
commit 75f1528
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 11 deletions.
diff --git a/examples/tv-app/android/include/content-launcher/AppContentLauncherManager.cpp b/examples/tv-app/android/include/content-launcher/AppContentLauncherManager.cpp
@@ -92,17 +92,19 @@ CHIP_ERROR AppContentLauncherManager::HandleGetAcceptHeaderList(AttributeValueEn
     {
         Json::Reader reader;
         Json::Value value;
-        reader.parse(resStr, value);
-        std::string attrId = to_string(chip::app::Clusters::ContentLauncher::Attributes::AcceptHeader::Id).c_str();
-        ChipLogProgress(Zcl,
-                        "AppContentLauncherManager::HandleGetSupportedStreamingProtocols response parsing done. reading attr %s",
-                        attrId.c_str());
-        if (value[attrId].isArray())
+        if (reader.parse(resStr, value))
         {
-            mAcceptHeaderList.clear();
-            for (Json::Value & entry : value[attrId])
+            std::string attrId = to_string(chip::app::Clusters::ContentLauncher::Attributes::AcceptHeader::Id);
+            ChipLogProgress(Zcl,
+                            "AppContentLauncherManager::HandleGetSupportedStreamingProtocols response parsing done. reading attr %s",
+                            attrId.c_str());
+            if (value[attrId].isArray())
             {
-                mAcceptHeaderList.push_back(entry.asString());
+                mAcceptHeaderList.clear();
+                for (Json::Value & entry : value[attrId])
+                {
+                    mAcceptHeaderList.push_back(entry.asString());
+                }
             }
         }
     }
@@ -132,7 +134,10 @@ uint32_t AppContentLauncherManager::HandleGetSupportedStreamingProtocols()
 
     Json::Reader reader;
     Json::Value value;
-    reader.parse(resStr, value);
+    if (!reader.parse(resStr, value))
+    {
+        return mSupportedStreamingProtocols;
+    }
     std::string attrId = to_string(chip::app::Clusters::ContentLauncher::Attributes::SupportedStreamingProtocols::Id);
     ChipLogProgress(Zcl, "AppContentLauncherManager::HandleGetSupportedStreamingProtocols response parsing done. reading attr %s",
                     attrId.c_str());

diff --git a/examples/tv-app/android/java/ContentAppCommandDelegate.cpp b/examples/tv-app/android/java/ContentAppCommandDelegate.cpp
@@ -112,7 +112,11 @@ void ContentAppCommandDelegate::FormatResponseData(CommandHandlerInterface::Hand
 {
     Json::Reader reader;
     Json::Value value;
-    reader.parse(response, value);
+    if (!reader.parse(response, value))
+    {
+        handlerContext.SetCommandNotHandled();
+        return;
+    }
 
     switch (handlerContext.mRequestPath.mClusterId)
     {