Skip to content

Commit

Permalink
Improve some CI actions (#9775)
Browse files Browse the repository at this point in the history
* Add missing ACT env conditions

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Switch to ubuntu virtual env for shuffle_names CI job

Signed-off-by: Victor Morales <v.morales@samsung.com>

* Use latest chip-build image on build_linux_python_lib job

Signed-off-by: Victor Morales <v.morales@samsung.com>
  • Loading branch information
electrocucaracha authored and pull[bot] committed Oct 12, 2021
1 parent 97aa365 commit 850fa64
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ jobs:
if: github.actor != 'restyled-io[bot]'

container:
image: connectedhomeip/chip-build:0.5.0
image: connectedhomeip/chip-build:latest
volumes:
- "/tmp/log_output:/tmp/test_logs"
options:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/examples-linux-standalone.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ jobs:
- name: Binary artifact suffix
id: outsuffix
uses: haya14busa/action-cond@v1.0.0
if: ${{ !env.ACT }}
with:
cond: ${{ github.event.pull_request.number == '' }}
if_true: "${{ github.sha }}"
Expand All @@ -135,6 +136,7 @@ jobs:
out/all_clusters_debug/all-clusters-server.map
- name: Uploading Size Reports
uses: actions/upload-artifact@v2
if: ${{ !env.ACT }}
with:
name: Size,Linux-Examples,${{ env.GH_EVENT_PR }},${{ env.GH_EVENT_HASH }},${{ env.GH_EVENT_PARENT }}
path: |
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/examples-qpg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ jobs:
- name: Binary artifact suffix
id: outsuffix
uses: haya14busa/action-cond@v1.0.0
if: ${{ !env.ACT }}
with:
cond: ${{ github.event.pull_request.number == '' }}
if_true: "${{ github.sha }}"
Expand All @@ -101,6 +102,7 @@ jobs:
out/lighting_app_debug/chip-qpg6100-lighting-example.out.map
- name: Uploading Size Reports
uses: actions/upload-artifact@v2
if: ${{ !env.ACT }}
with:
name: Size,QPG-Examples,${{ env.GH_EVENT_PR }},${{ env.GH_EVENT_HASH }},${{ env.GH_EVENT_PARENT }}
path: |
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/fixit_rotation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ jobs:
shuffle_names:
name: Shuffle names
runs-on: ubuntu-latest
container:
image: connectedhomeip/chip-build:latest

steps:
- name: Checkout
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/unit_integration_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ jobs:
- name: Artifact suffix
id: outsuffix
uses: haya14busa/action-cond@v1.0.0
if: ${{ !env.ACT }}
with:
cond: ${{ github.event.pull_request.number == '' }}
if_true: "${{ github.sha }}"
Expand Down

0 comments on commit 850fa64

Please sign in to comment.