-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[IM] Implement list chunking feature (#12019)
* Update AttributeValueEncoder * TagBoundEncoder -> ListEncodeHelper * Fix Null ListIndex support * Offload build logic to separate class * Add attribute for testing list chunking * Fix Error * Add even more tests * auto -> const auto * * Address comments * Update * Update Encode * Update * Update * Update * Fix style * Fix * Run Codegen
- Loading branch information
Showing
81 changed files
with
3,615 additions
and
1,947 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| /* | ||
| * | ||
| * Copyright (c) 2021 Project CHIP Authors | ||
| * All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #include <app/AttributeAccessInterface.h> | ||
|
|
||
| namespace chip { | ||
| namespace app { | ||
|
|
||
| CHIP_ERROR AttributeReportBuilder::PrepareAttribute(AttributeReportIBs::Builder & aAttributeReportIBsBuilder, | ||
| const ConcreteDataAttributePath & aPath, DataVersion aDataVersion) | ||
| { | ||
| mAttributeReportIBBuilder = aAttributeReportIBsBuilder.CreateAttributeReport(); | ||
| ReturnErrorOnFailure(aAttributeReportIBsBuilder.GetError()); | ||
|
|
||
| mAttributeDataIBBuilder = mAttributeReportIBBuilder.CreateAttributeData(); | ||
| ReturnErrorOnFailure(mAttributeReportIBBuilder.GetError()); | ||
|
|
||
| mAttributeDataIBBuilder.DataVersion(aDataVersion); | ||
|
|
||
| auto attributePathIBBuilder = mAttributeDataIBBuilder.CreatePath(); | ||
| ReturnErrorOnFailure(mAttributeDataIBBuilder.GetError()); | ||
|
|
||
| attributePathIBBuilder.Endpoint(aPath.mEndpointId).Cluster(aPath.mClusterId).Attribute(aPath.mAttributeId); | ||
|
|
||
| if (aPath.mListOp == ConcreteDataAttributePath::ListOperation::AppendItem) | ||
| { | ||
| // An append to a list (or a data chunk consisting just one list entry that's part of a bigger list) is represented by a | ||
| // null list index in the path. | ||
| attributePathIBBuilder.ListIndex(DataModel::Nullable<ListIndex>()); | ||
| } | ||
|
|
||
| ReturnErrorOnFailure(attributePathIBBuilder.EndOfAttributePathIB().GetError()); | ||
|
|
||
| return mAttributeDataIBBuilder.GetError(); | ||
| } | ||
|
|
||
| CHIP_ERROR AttributeReportBuilder::FinishAttribute() | ||
| { | ||
| ReturnErrorOnFailure(mAttributeDataIBBuilder.EndOfAttributeDataIB().GetError()); | ||
| return mAttributeReportIBBuilder.EndOfAttributeReportIB().GetError(); | ||
| } | ||
|
|
||
| CHIP_ERROR AttributeValueEncoder::EncodeEmptyList() | ||
| { | ||
| if (mCurrentEncodingListIndex == kInvalidListIndex) | ||
| { | ||
| if (mEncodeState.mCurrentEncodingListIndex == kInvalidListIndex) | ||
| { | ||
| // Clear mAllowPartialData flag here since this encode procedure is not atomic. | ||
| // The most common error in this function is CHIP_ERROR_NO_MEMORY / CHIP_ERROR_BUFFER_TOO_SMALL, just revert and try | ||
| // next time is ok. | ||
| mEncodeState.mAllowPartialData = false; | ||
| // Spec 10.5.4.3.1, 10.5.4.6 (Replace a list w/ Multiple IBs) | ||
| // Put an empty array before encoding the first array element for list chunking. | ||
| AttributeReportBuilder builder; | ||
|
|
||
| ReturnErrorOnFailure(builder.PrepareAttribute(mAttributeReportIBsBuilder, mPath, mDataVersion)); | ||
| ReturnErrorOnFailure(builder.EncodeValue(DataModel::List<uint8_t>())); | ||
|
|
||
| ReturnErrorOnFailure(builder.FinishAttribute()); | ||
| mEncodeState.mCurrentEncodingListIndex = 0; | ||
| } | ||
| mCurrentEncodingListIndex = 0; | ||
| } | ||
|
|
||
| // After encoding the empty list, the remaining items are atomically encoded into the buffer. Tell report engine to not | ||
| // revert partial data. | ||
| mEncodeState.mAllowPartialData = true; | ||
|
|
||
| return CHIP_NO_ERROR; | ||
| } | ||
|
|
||
| } // namespace app | ||
| } // namespace chip |
Oops, something went wrong.