Skip to content

Commit

Permalink
ESP32: Move the BLE deinit after BLE connection is closed, post commi…
Browse files Browse the repository at this point in the history
…ssioning (#26183)
  • Loading branch information
dhrishi authored Apr 25, 2023
1 parent 85fd5ce commit c2a28c8
Showing 1 changed file with 38 additions and 28 deletions.
66 changes: 38 additions & 28 deletions examples/platform/esp32/common/CommonDeviceCallbacks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
#include "esp_heap_caps.h"
#include "esp_log.h"
#include <app/server/Dnssd.h>
#include <app/server/Server.h>
#include <app/util/util.h>
#include <lib/support/CodeUtils.h>
#if CONFIG_ENABLE_OTA_REQUESTOR
Expand Down Expand Up @@ -61,6 +62,43 @@ void CommonDeviceCallbacks::DeviceEventCallback(const ChipDeviceEvent * event, i

case DeviceEventType::kCHIPoBLEConnectionClosed:
ESP_LOGI(TAG, "CHIPoBLE disconnected");
#if CONFIG_BT_ENABLED
#if CONFIG_USE_BLE_ONLY_FOR_COMMISSIONING

if (chip::Server::GetInstance().GetFabricTable().FabricCount() > 0)
{
esp_err_t err = ESP_OK;
#if CONFIG_BT_NIMBLE_ENABLED
if (ble_hs_is_enabled())
{
int ret = nimble_port_stop();
if (ret == 0)
{
nimble_port_deinit();
#if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 0, 0)
err = esp_nimble_hci_and_controller_deinit();
#endif // ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 0, 0)
#endif // CONFIG_BT_NIMBLE_ENABLED

#if CONFIG_IDF_TARGET_ESP32
err += esp_bt_mem_release(ESP_BT_MODE_BTDM);
#elif CONFIG_IDF_TARGET_ESP32C2 || CONFIG_IDF_TARGET_ESP32C3 || CONFIG_IDF_TARGET_ESP32S3 || CONFIG_IDF_TARGET_ESP32H2
err += esp_bt_mem_release(ESP_BT_MODE_BLE);
#endif
if (err == ESP_OK)
{
ESP_LOGI(TAG, "BLE deinit successful and memory reclaimed");
}
}
else
{
ESP_LOGW(TAG, "nimble_port_stop() failed");
}
}
else { ESP_LOGI(TAG, "BLE already deinited"); }
}
#endif // CONFIG_USE_BLE_ONLY_FOR_COMMISSIONING
#endif // CONFIG_BT_ENABLED
break;

case DeviceEventType::kDnssdInitialized:
Expand All @@ -76,34 +114,6 @@ void CommonDeviceCallbacks::DeviceEventCallback(const ChipDeviceEvent * event, i

case DeviceEventType::kCommissioningComplete: {
ESP_LOGI(TAG, "Commissioning complete");
#if CHIP_DEVICE_CONFIG_ENABLE_CHIPOBLE && CONFIG_BT_NIMBLE_ENABLED && CONFIG_USE_BLE_ONLY_FOR_COMMISSIONING

if (ble_hs_is_enabled())
{
int ret = nimble_port_stop();
esp_err_t err = ESP_OK;
if (ret == 0)
{
nimble_port_deinit();
#if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 0, 0)
err = esp_nimble_hci_and_controller_deinit();
#endif // ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 0, 0)
err += esp_bt_mem_release(ESP_BT_MODE_BTDM);
if (err == ESP_OK)
{
ESP_LOGI(TAG, "BLE deinit successful and memory reclaimed");
}
}
else
{
ESP_LOGW(TAG, "nimble_port_stop() failed");
}
}
else
{
ESP_LOGI(TAG, "BLE already deinited");
}
#endif
}
break;

Expand Down

0 comments on commit c2a28c8

Please sign in to comment.