Fix null pointer issue in CHIPMemString

project-chip · Sep 30, 2024 · c32fc4d · c32fc4d
1 parent 6bbe1d6
commit c32fc4d
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/lib/support/CHIPMemString.h b/src/lib/support/CHIPMemString.h
@@ -121,12 +121,20 @@ inline void CopyString(char (&dest)[N], ByteSpan source)
  */
 inline void CopyString(char * dest, size_t destLength, CharSpan source)
 {
-    if (dest && destLength)
+    if ((dest == nullptr) || (destLength == 0))
     {
-        size_t maxChars = std::min(destLength - 1, source.size());
-        memcpy(dest, source.data(), maxChars);
-        dest[maxChars] = '\0';
+        return; // no space to copy anything, not even a null terminator
     }
+
+    if (source.empty())
+    {
+        *dest = '\0'; // just a null terminator, we are copying empty data
+        return;
+    }
+
+    size_t maxChars = std::min(destLength - 1, source.size());
+    memcpy(dest, source.data(), maxChars);
+    dest[maxChars] = '\0';
 }
 
 /**