Skip to content

Commit

Permalink
Remove dead-code init callbacks from some clusters. (#27936)
Browse files Browse the repository at this point in the history
Init callbacks are only called for clusters listed in
ClustersWithInitFunctions.  "Basic" was not the right name for "Basic
Information", so that one was effectively not listed, and neither "Refrigerator
Alarm" nor "Group Key Management" were listed.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Aug 3, 2023
1 parent 55e78ee commit c530d26
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 7 deletions.
2 changes: 0 additions & 2 deletions src/app/clusters/basic-information/basic-information.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,6 @@ bool IsLocalConfigDisabled()
} // namespace app
} // namespace chip

void emberAfBasicInformationClusterServerInitCallback(chip::EndpointId endpoint) {}

void MatterBasicInformationPluginServerInitCallback()
{
registerAttributeAccessOverride(&gAttrAccess);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,6 @@ void MatterGroupKeyManagementPluginServerInitCallback()
// Commands
//

void emberAfGroupKeyManagementClusterServerInitCallback(chip::EndpointId endpoint) {}

bool emberAfGroupKeyManagementClusterKeySetWriteCallback(
chip::app::CommandHandler * commandObj, const chip::app::ConcreteCommandPath & commandPath,
const chip::app::Clusters::GroupKeyManagement::Commands::KeySetWrite::DecodableType & commandData)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,4 @@ void RefrigeratorAlarmServer::SendNotifyEvent(EndpointId endpointId, BitMask<Ala
* Callbacks Implementation
*********************************************************/

void emberAfRefrigeratorAlarmClusterServerInitCallback(EndpointId endpoint) {}

void MatterRefrigeratorAlarmPluginServerInitCallback() {}
1 change: 0 additions & 1 deletion src/app/common/templates/config-data.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ CommandHandlerInterfaceOnlyClusters:
# We need a more configurable way of deciding which clusters have which init functions....
# See https://github.com/project-chip/connectedhomeip/issues/4369
ClustersWithInitFunctions:
- Basic
- Color Control
- Groups
- Identify
Expand Down

0 comments on commit c530d26

Please sign in to comment.