New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension support to access control #10252

Closed

mlepage-google opened this issue Oct 5, 2021 · 3 comments

Assignees

Labels

acl V1.0

Contributor

mlepage-google commented Oct 5, 2021 •

edited

Loading

We'll do this last, since it's basically a copy/paste of ACL attribute support to handle the similar-but-simpler extension attribute.

Includes:

extension support in the module
extension persistence
read extension in the cluster
write extension in the cluster
event notification in the cluster
whatever else ACL does, check if extension needs to do it as well

mlepage-google added the acl label

This was referenced Oct 5, 2021

Design AccessControlProvider interface #10249

Closed

Implement AccessControlProvider in-memory data structures #10250

Closed

Implement simple access control cluster persistence/storage #10251

Closed

mlepage-google mentioned this issue

Implement ACL attribute read/write #12305

Merged

woody-apple added the V1.0 label

mlepage-google changed the title ~~Add extensions to AccessControlProvider~~ Add extension support to access control

andy31415 added the v1_triage_split_7 label

kpschoedel removed the v1_triage_split_7 label

kpschoedel assigned mlepage-google

Contributor Author

mlepage-google commented Apr 1, 2022

Spec PR reduces extension size from 254 to 128, so also do that change for SDK as part of this work.
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5079

mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue


          Add extension attribute to access control cluster

ebddcdd

Includes attribute. Does not include events, or fabric removal.

Part of issue project-chip#10252

mlepage-google mentioned this issue

Add extension attribute to access control cluster #17008

Merged

Contributor Author

mlepage-google commented Apr 4, 2022

Note PR #17008 adds extension attribute support with events, but doesn't handle the fabric removal part which is also necessary. This issue will stay open until that part is done as well.

mlepage-google added a commit to mlepage-google/connectedhomeip that referenced this issue


          Support remove fabric for access control extension

7647d96

Extension attribute needs its fabric scoped data removed
when the fabric is removed.

Part of issue project-chip#10252

mlepage-google mentioned this issue

Support remove fabric for access control extension #17032

Merged

woody-apple pushed a commit that referenced this issue


          Add extension attribute to access control cluster (#17008)

70a6caa

* Add extension attribute to access control cluster

Includes attribute. Does not include events, or fabric removal.

Part of issue #10252

* Remove temp log

* Add extension event support

Also change the keys for storing extensions based on review feedback.

* Relax VerifyOrDie

Use CHIP_ERROR_INCORRECT_STATE instead.

* Update src/app/clusters/access-control-server/access-control-server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Change some error codes

For invalid octstr length and invalid list length, instead use
constraint error.

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

woody-apple pushed a commit to mlepage-google/connectedhomeip that referenced this issue


          Support remove fabric for access control extension

7c64305

Extension attribute needs its fabric scoped data removed
when the fabric is removed.

Part of issue project-chip#10252

mlepage-google added a commit that referenced this issue


          Support remove fabric for access control extension (#17032)

2ff1d72

Extension attribute needs its fabric scoped data removed
when the fabric is removed.

Part of issue #10252

Contributor Author

mlepage-google commented Apr 5, 2022

PR #17032 added remove fabric support. Therefore this feature is done.

mlepage-google closed this as completed

chencheung pushed a commit to chencheung/connectedhomeip that referenced this issue


          Add extension attribute to access control cluster (project-chip#17008)

c9daf35

* Add extension attribute to access control cluster

Includes attribute. Does not include events, or fabric removal.

Part of issue project-chip#10252

* Remove temp log

* Add extension event support

Also change the keys for storing extensions based on review feedback.

* Relax VerifyOrDie

Use CHIP_ERROR_INCORRECT_STATE instead.

* Update src/app/clusters/access-control-server/access-control-server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Change some error codes

For invalid octstr length and invalid list length, instead use
constraint error.

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

chencheung pushed a commit to chencheung/connectedhomeip that referenced this issue


          Support remove fabric for access control extension (project-chip#17032)

784f01f

Extension attribute needs its fabric scoped data removed
when the fabric is removed.

Part of issue project-chip#10252

chencheung pushed a commit to chencheung/connectedhomeip that referenced this issue


          Add extension attribute to access control cluster (project-chip#17008)

85ae4e3

* Add extension attribute to access control cluster

Includes attribute. Does not include events, or fabric removal.

Part of issue project-chip#10252

* Remove temp log

* Add extension event support

Also change the keys for storing extensions based on review feedback.

* Relax VerifyOrDie

Use CHIP_ERROR_INCORRECT_STATE instead.

* Update src/app/clusters/access-control-server/access-control-server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Change some error codes

For invalid octstr length and invalid list length, instead use
constraint error.

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

chencheung pushed a commit to chencheung/connectedhomeip that referenced this issue


          Support remove fabric for access control extension (project-chip#17032)

a96adaa

Extension attribute needs its fabric scoped data removed
when the fabric is removed.

Part of issue project-chip#10252

andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this issue


          Add extension attribute to access control cluster (project-chip#17008)

d00ac68

* Add extension attribute to access control cluster

Includes attribute. Does not include events, or fabric removal.

Part of issue project-chip#10252

* Remove temp log

* Add extension event support

Also change the keys for storing extensions based on review feedback.

* Relax VerifyOrDie

Use CHIP_ERROR_INCORRECT_STATE instead.

* Update src/app/clusters/access-control-server/access-control-server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Change some error codes

For invalid octstr length and invalid list length, instead use
constraint error.

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this issue


          Support remove fabric for access control extension (project-chip#17032)

8f5b80c

Extension attribute needs its fabric scoped data removed
when the fabric is removed.

Part of issue project-chip#10252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment