Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address review comments on content app platform #12543

Closed
bzbarsky-apple opened this issue Dec 3, 2021 · 1 comment
Closed

Address review comments on content app platform #12543

bzbarsky-apple opened this issue Dec 3, 2021 · 1 comment
Assignees
@chrisdecenzo
Labels
app-clusters Application cluster work security V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

The code landed in #12125 has a number of critical security bugs (buffer overflows, dangling pointers), as well as various functionality issues that need to be fixed.

See #12125 (review) though I have very low confidence that I found all the problems, especially because the code is clearly completely untested.

Proposed Solution

Fix issues. Add tests.
@chrisdecenzo chrisdecenzo mentioned this issue Jan 7, 2022
Merged
@woody-apple woody-apple added the app-clusters Application cluster work label Feb 8, 2022
@chrisdecenzo chrisdecenzo mentioned this issue May 13, 2022
Merged
@chrisdecenzo
Copy link
Contributor

I believe all issues cited have been addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdecenzo chrisdecenzo

Labels
app-clusters Application cluster work security V1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@andy31415 @cecille @woody-apple @chrisdecenzo @bzbarsky-apple @franck-apple