Link attribute reads to Content Apps, refactor content app platform to leverage latest cluster lib conventions #12969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple and
robszewczyk
bzbarsky-apple
approved these changes
Jan 25, 2022
|
Fast tracking, given > 3 days for review. |
|
PR #12969: Size comparison from e45f0a1 to c6bc7b9 Decreases (1 build for p6)
Full report (4 builds for p6, telink)
|
andy31415
reviewed
Jan 26, 2022
andy31415
reviewed
Jan 26, 2022
andy31415
reviewed
Jan 27, 2022
andy31415
reviewed
Jan 27, 2022
andy31415
requested changes
Jan 27, 2022
andy31415
approved these changes
Jan 27, 2022
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
…o leverage latest cluster lib conventions (project-chip#12969) * link attribute reads to Content Apps * address some comments * route attribute reads and writes to per-cluster handlers * refactor content app * straggler * use MEI log format commands * fix tv-app test suites * fix tv-app test suites * fix CI test suites * fix CI test suites * add bindings call * migrate content app to use new account login delegate * refactor ContentApp to use delegates * fix CI errors * fix CI errors * fix CI errors * more ContentApp to app-platform directory * address issue 13144 * address issue 12543 * address comments * address comments * fix handling of application launcher, application basic status and content platform * fix build * fix android build * fix android build * add Commissioner Discovery Controller to manage UDC workflow * address comments * address comments * fix builds * fix builds * fix builds * address comments * fix potential leak on commands * fix potential leak on attribute reads * fix potential leak on attribute reads * argument and naming consistency * fix android build * fix android build * fix android build * fix android build * address easy comments * fix android build * fix android * fix merge issue * optimize image size * fix build * attempt to fix CI build * attempt to fix CI build * attempt to fix CI build * reduce dependencies Co-authored-by: Christopher DeCenzo <decenzo@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
For all Content App clusters, make sure commands and attributes are linked to Content Apps
Testing
TBD