We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoadContentApp
examples/tv-app/linux/AppImpl.h
CatalogVendorApp
bool Matches(CatalogVendorApp app)
CreateBindingWithCallback
kCatalogVendorId
examples/tv-app
chip::VendorId
std::underlying_type_t<relevant-spec-enum>
uint32_t
src/app/BUILD.gn
-Wconversion
The text was updated successfully, but these errors were encountered:
These all look addressed, please re-open if not!
Sorry, something went wrong.
chrisdecenzo
No branches or pull requests
Problem
Proposed Solution
LoadContentApp
inexamples/tv-app/linux/AppImpl.h
and various other places should perhaps takeCatalogVendorApp
by reference, not by value.bool Matches(CatalogVendorApp app)
should perhaps take the thing to match by reference.CreateBindingWithCallback
API should not exist and certainly should not be using the old CHIPClusters command API we are trying to remove.CreateBindingWithCallback
.kCatalogVendorId
and various vendor id use inexamples/tv-app
should probably usechip::VendorId
.std::underlying_type_t<relevant-spec-enum>
instead of hardcodinguint32_t
.src/app/BUILD.gn
) where they will be compiled with-Wconversion
? Though it's possible this is not relevant and they are being built that way, at least for the Linux tv-app. Should check!The text was updated successfully, but these errors were encountered: