Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address review comments on PR 12634 #13144

Closed
bzbarsky-apple opened this issue Dec 18, 2021 · 1 comment
Closed

Address review comments on PR 12634 #13144

bzbarsky-apple opened this issue Dec 18, 2021 · 1 comment
Assignees
@chrisdecenzo
Labels
security V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

See #12634 (review)

The bits about handing out uint8_t * without any length indication are a security bug waiting to happen.

Proposed Solution

Fix the comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdecenzo chrisdecenzo

Labels
security V1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andy31415 @holbrookt @woody-apple @chrisdecenzo @bzbarsky-apple