Handle fabric removal, factory reset in access control #13876
Comments
mlepage-google
changed the title
mlepage-google
added a commit
to mlepage-google/connectedhomeip
that referenced
this issue
Mar 25, 2022
Use the "public" API to delete entries for a fabric. Tested (on Linux using chip-all-clusters-app and chip-tool) by commissioning on three fabrics, with 3, 2, and 2 distinct ACLs, then removing the second (middle) fabric, and verifying that the remaining 5 ACLs are preserved, even after restart. Part of issue project-chip#13876 (fabric removal and factory reset)
bzbarsky-apple
pushed a commit
that referenced
this issue
Mar 26, 2022
Use the "public" API to delete entries for a fabric. Tested (on Linux using chip-all-clusters-app and chip-tool) by commissioning on three fabrics, with 3, 2, and 2 distinct ACLs, then removing the second (middle) fabric, and verifying that the remaining 5 ACLs are preserved, even after restart. Part of issue #13876 (fabric removal and factory reset)
|
Turns out factory data reset isn't really a spec-compliant feature, so handling fabric removal is all that's necessary for now. |
|
What's in master branch (PR #16685) is working correctly, but overzealous with persistence. We already have an issue to improve persistence (#14451) so this issue can be closed as the feature is working, and remove fabric is a rare procedure so overzealous persistence is not necessarily an issue anyways. |
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this issue
Mar 31, 2022
Use the "public" API to delete entries for a fabric. Tested (on Linux using chip-all-clusters-app and chip-tool) by commissioning on three fabrics, with 3, 2, and 2 distinct ACLs, then removing the second (middle) fabric, and verifying that the remaining 5 ACLs are preserved, even after restart. Part of issue project-chip#13876 (fabric removal and factory reset)
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this issue
Apr 14, 2022
Use the "public" API to delete entries for a fabric. Tested (on Linux using chip-all-clusters-app and chip-tool) by commissioning on three fabrics, with 3, 2, and 2 distinct ACLs, then removing the second (middle) fabric, and verifying that the remaining 5 ACLs are preserved, even after restart. Part of issue project-chip#13876 (fabric removal and factory reset)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When we have a framework for fabric removal and factory reset, need to handle that.
E.g. fabric 3 removed (but not 1, 2, or 4) --> need to remove ACL entries for fabric 3 only.
Also tests.
The text was updated successfully, but these errors were encountered: