Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge "nRF" and "nRF Connect" Dockerfiles #1549

Closed
Damian-Nordic opened this issue Jul 10, 2020 · 0 comments · Fixed by #1577
Closed

Merge "nRF" and "nRF Connect" Dockerfiles #1549

Damian-Nordic opened this issue Jul 10, 2020 · 0 comments · Fixed by #1577

Comments

@Damian-Nordic
Copy link
Contributor

Problem

As @rwalker-apple pointed out in #1529 Dockerfiles for nrf and nrfconnect platforms share some dependencies, so the scripts might be merged to avoid maintenance burden related to the need to update them both in the future.

Proposed Solution

  • nrf and nrfconnect Dockerfiles merged into a single multi-stage Dockerfile
  • change in integrations/docker/build.sh to support selection of a target from a multi-stage Dockerfile.

I will take care to implement the solution.
@Damian-Nordic Damian-Nordic mentioned this issue Jul 13, 2020
Merged
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue Feb 15, 2024
@su-shanka
Pull request project-chip#1549: NoJira: Updated unify docs with new b…
a325607 
…uild command

Squashed commit of the following:

commit 9b675a07ef841b03be33a000f4738dfe1f4df03b
Author: Suhas Shankar <suhas.shankar@silabs.com>
Date:   Wed Jan 31 14:36:42 2024 +0530

    Doc updates for build command
jmartinez-silabs pushed a commit to SiliconLabs/matter that referenced this issue May 8, 2024
@su-shanka @jmartinez-silabs
Pull request project-chip#1549: NoJira: Updated unify docs with new b…
16ad660 
…uild command

Squashed commit of the following:

commit 9b675a07ef841b03be33a000f4738dfe1f4df03b
Author: Suhas Shankar <suhas.shankar@silabs.com>
Date:   Wed Jan 31 14:36:42 2024 +0530

    Doc updates for build command
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this issue Jun 20, 2024
@su-shanka
Pull request project-chip#1549: NoJira: Updated unify docs with new b…
6709e40 
…uild command

Squashed commit of the following:

commit 9b675a07ef841b03be33a000f4738dfe1f4df03b
Author: Suhas Shankar <suhas.shankar@silabs.com>
Date:   Wed Jan 31 14:36:42 2024 +0530

    Doc updates for build command
rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this issue Jun 20, 2024
@su-shanka @jmartinez-silabs
Pull request project-chip#1549: NoJira: Updated unify docs with new b…
8284023 
…uild command

Squashed commit of the following:

commit 9b675a07ef841b03be33a000f4738dfe1f4df03b
Author: Suhas Shankar <suhas.shankar@silabs.com>
Date:   Wed Jan 31 14:36:42 2024 +0530

    Doc updates for build command
chirag-silabs pushed a commit to rosahay-silabs/connectedhomeip that referenced this issue Jul 15, 2024
@su-shanka @jmartinez-silabs
Pull request project-chip#1549: NoJira: Updated unify docs with new b…
0aafff3 
…uild command

Squashed commit of the following:

commit 9b675a07ef841b03be33a000f4738dfe1f4df03b
Author: Suhas Shankar <suhas.shankar@silabs.com>
Date:   Wed Jan 31 14:36:42 2024 +0530

    Doc updates for build command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge nRF and nRF Connect Dockerfiles Damian-Nordic/connectedhomeip
1 participant
@Damian-Nordic