Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move breadcrumb attribute to attribute store. #17515

Closed
cecille opened this issue Apr 19, 2022 · 1 comment · Fixed by #17769
Closed

Move breadcrumb attribute to attribute store. #17515

cecille opened this issue Apr 19, 2022 · 1 comment · Fixed by #17769
Labels
spec Mismatch between spec and implementation V1.0

Comments

@cecille
Copy link
Contributor

cecille commented Apr 19, 2022

Problem

Breadcrumb attribute was stored in the config manager originally, but should be moved over to use the attribute store.

Proposed Solution

Change code to use attribute store, remove from config manager.
@cecille cecille mentioned this issue Apr 19, 2022
Merged
@bzbarsky-apple bzbarsky-apple added V1.0 spec Mismatch between spec and implementation labels Apr 19, 2022
@bzbarsky-apple
Copy link
Contributor

Needed for spec compliance: this attribute is not supposed to persist across reboots.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 26, 2022
@bzbarsky-apple
Stop storing breadcrumb in persistent storage.
27e8a8c 
Breadcrumb is not supposed to be stored persistently.

Also adds a bunch of tests and fixes various bugs where we were
setting breadcrumbs when we should not (e.g. in error conditions) and
not setting them when we should (e.g. when the fail-safe expires).

Fixes project-chip#17515
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 26, 2022
@bzbarsky-apple
Stop storing breadcrumb in persistent storage.
9893c6b 
Breadcrumb is not supposed to be stored persistently.

Also adds a bunch of tests and fixes various bugs where we were
setting breadcrumbs when we should not (e.g. in error conditions) and
not setting them when we should (e.g. when the fail-safe expires).

Fixes project-chip#17515
@bzbarsky-apple bzbarsky-apple mentioned this issue Apr 26, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 26, 2022
@bzbarsky-apple
Stop storing breadcrumb in persistent storage.
de3b274 
Breadcrumb is not supposed to be stored persistently.

Also adds a bunch of tests and fixes various bugs where we were
setting breadcrumbs when we should not (e.g. in error conditions) and
not setting them when we should (e.g. when the fail-safe expires).

Fixes project-chip#17515
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 26, 2022
@bzbarsky-apple
Stop storing breadcrumb in persistent storage.
d920bbb 
Breadcrumb is not supposed to be stored persistently.

Also adds a bunch of tests and fixes various bugs where we were
setting breadcrumbs when we should not (e.g. in error conditions) and
not setting them when we should (e.g. when the fail-safe expires).

Fixes project-chip#17515
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 27, 2022
@bzbarsky-apple
Stop storing breadcrumb in persistent storage.
543e8fe 
Breadcrumb is not supposed to be stored persistently.

Also adds a bunch of tests and fixes various bugs where we were
setting breadcrumbs when we should not (e.g. in error conditions) and
not setting them when we should (e.g. when the fail-safe expires).

Fixes project-chip#17515
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Apr 27, 2022
@bzbarsky-apple
Stop storing breadcrumb in persistent storage.
566f943 
Breadcrumb is not supposed to be stored persistently.

Also adds a bunch of tests and fixes various bugs where we were
setting breadcrumbs when we should not (e.g. in error conditions) and
not setting them when we should (e.g. when the fail-safe expires).

Fixes project-chip#17515
mspang pushed a commit that referenced this issue Apr 27, 2022
@bzbarsky-apple
Stop storing breadcrumb in persistent storage. (#17769)
4517de3 
Breadcrumb is not supposed to be stored persistently.

Also adds a bunch of tests and fixes various bugs where we were
setting breadcrumbs when we should not (e.g. in error conditions) and
not setting them when we should (e.g. when the fail-safe expires).

Fixes #17515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec Mismatch between spec and implementation V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop storing breadcrumb in persistent storage. bzbarsky-apple/connectedhomeip
2 participants
@cecille @bzbarsky-apple