Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-IDM-4.3]--Chip tool needs to provide a way to set MinIntervalFloor value > MinIntervalFloor value For subscription request. #18839

Closed
Rajashreekalmane opened this issue May 26, 2022 · 7 comments · Fixed by #18855
Assignees

Comments

@Rajashreekalmane
Copy link

Rajashreekalmane commented May 26, 2022

Problem

As per Test-Plan, step 21 says TH sends a subscription request action for attribute and set the MinIntervalFloor value to be greater than MaxIntervalCeiling, and expecting response as DUT sends an error message and the subscription is not established.
Chip tool needs to provide a way to set MinIntervalFloor value > MaxIntervalCeiling value when TH sends a subscription request action for attribute to DUT.

Test-Plan screenshot:-
image

Spec Reference:-
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/data_model/Interaction-Model.adoc#subscribe-response-action

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented May 26, 2022

@Rajashreekalmane @cjandhyala I don't understand this issue. The test plan says to set MinIntervalFloor to the same value as MaxIntervalCeiling (which chip-tool supports), but the text of the issue talks about setting MinIntervalFloor > MinIntervalFloor, which is obviously not possible.

@bzbarsky-apple
Copy link
Contributor

I am guessing this issue is actually about step 21, not step 20, and that the request is that we allow MinIntervalFloor > MaxIntervalCeiling?

If so, that's not allowed in the SDK right now, so adding it to chip-tool is not exactly trivial.

@andy31415
Copy link
Contributor

Are we supposed to cert-block on negative test cases? I imagine many of these may be non-trivial to implement.

@cjandhyala what is the policy here? I would be inclined to not block on "allow invalid values to be accepted by tooling" or at least separate these cases a bit, since we will want some flags/builds/error injection capability for "I am providing invalid values but I know what I am doing and really need it"

@woody-apple
Copy link
Contributor

Cert Blocker Review: Looks like this is in active discussion with @vivien-apple and @cjandhyala

@Rajashreekalmane
Copy link
Author

Rajashreekalmane commented May 26, 2022

@bzbarsky-apple Yes the issue is on step 21 , I have updated the issue Now.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 26, 2022
This allows chip-tool to test server behavior when
MinIntervalFloor > MaxIntervalCeiling.

Fixes project-chip#18839
@mrjerryjohns
Copy link
Contributor

I don't think is validatable without modifications to the IM implementation in the SDK to permit this 'test modality' and skips initial validation of these parameters.

I'd recommend we skip this test.

@bzbarsky-apple
Copy link
Contributor

@mrjerryjohns See #18855

bzbarsky-apple added a commit that referenced this issue May 27, 2022
)

This allows chip-tool to test server behavior when
MinIntervalFloor > MaxIntervalCeiling.

Fixes #18839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants