Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Apply API review fixes for MTRThreadOperationalDataset #22544

Closed
bzbarsky-apple opened this issue Sep 12, 2022 · 0 comments · Fixed by #22562
Closed

[Platform] Apply API review fixes for MTRThreadOperationalDataset #22544

bzbarsky-apple opened this issue Sep 12, 2022 · 0 comments · Fixed by #22562
Assignees
@bzbarsky-apple
Labels
darwin V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Sep 12, 2022 •
edited
Loading

Reproduction steps

  1. Document.
  2. Remove "CHIP" bits in comments and move the commeng about initWithNetworkName to right before initWithNetworkName.
  3. Make various keys non-nullable.

Part of #22420 and independent of the other work going on in that issue.

Platform

darwin

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response
@bzbarsky-apple bzbarsky-apple self-assigned this Sep 12, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 12, 2022
@bzbarsky-apple
Address Darwin API review comments on MTRThreadOperationalDataset
23fa5d7 
* Improve documentation
* Actually use our size constants in the error-checks we do.
* Make the properties non-nullable, since we always have them after successful
  init.

Fixes project-chip#22544

Addresses part of project-chip#22420
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 12, 2022
@bzbarsky-apple
Address Darwin API review comments on MTRThreadOperationalDataset.
d3cab31 
* Improve documentation
* Actually use our size constants in the error-checks we do.
* Make the properties non-nullable, since we always have them after successful
  init.

Fixes project-chip#22544

Addresses part of project-chip#22420
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 12, 2022
Merged
bzbarsky-apple added a commit that referenced this issue Sep 13, 2022
@bzbarsky-apple
Address Darwin API review comments on MTRThreadOperationalDataset. (#…
5caec5a 
…22562)

* Improve documentation
* Actually use our size constants in the error-checks we do.
* Make the properties non-nullable, since we always have them after successful
  init.

Fixes #22544

Addresses part of #22420
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this issue Sep 16, 2022
@bzbarsky-apple @isiu-apple
Address Darwin API review comments on MTRThreadOperationalDataset. (p…
4d25239 
…roject-chip#22562)

* Improve documentation
* Actually use our size constants in the error-checks we do.
* Make the properties non-nullable, since we always have them after successful
  init.

Fixes project-chip#22544

Addresses part of project-chip#22420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address Darwin API review comments on MTRThreadOperationalDataset bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple