Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] ConnectWiFiNetworkAsync doesn't support WPA3 (SAE) #23402

Closed
afeatherstone-mm opened this issue Oct 31, 2022 · 2 comments · Fixed by #23404
Closed

[BUG] ConnectWiFiNetworkAsync doesn't support WPA3 (SAE) #23402

afeatherstone-mm opened this issue Oct 31, 2022 · 2 comments · Fixed by #23404
Labels
linux stale Stale issue or PR

Comments

@afeatherstone-mm
Copy link
Contributor

afeatherstone-mm commented Oct 31, 2022 •
edited
Loading

Reproduction steps

From the definition of the AddOrUpdateWiFiNetwork Command in section 11.8.8.4 of [1]

Security type, cipher and credential format (passphrase or PSK) SHALL be contextually auto-selected during execution of the ConnectNetwork Command and during subsequent operational state network connections, based on the most secure Wi-Fi security type available within beacons and probe responses for the set of all discovered BSSIDs for the configured SSID.

In the handling of the ConnectNetwork Command in ConnectWiFiNetworkAsync, the key_mgmt is hardcoded to WPA-PSK

g_variant_builder_add(&builder, "{sv}", "key_mgmt", g_variant_new_string("WPA-PSK"));

For networks that only support SAE, this results in the DUT failing to authenticate to the network.

[1] Matter Specification Version 1.0, document 22-22349-001_Matter-1.0-Core-Specification.pdf

Bug prevalence

Whenever I do this

GitHub hash of the SDK that was being used

v1.0

Platform

raspi

Platform Version(s)

No response

Anything else?

No response
afeatherstone-mm added a commit to afeatherstone-mm/connectedhomeip that referenced this issue Oct 31, 2022
@afeatherstone-mm
Add support for WPA3 (SAE) on Linux
4d67da8 
wpa_supplicant will use SAE, if required by the network. Support for
WPA3 is required as part of v1.0 of the Matter Specification (refer to
11.8.8.4 for details).

Resolves project-chip#23402.
@afeatherstone-mm afeatherstone-mm mentioned this issue Oct 31, 2022
Merged
afeatherstone-mm added a commit to afeatherstone-mm/connectedhomeip that referenced this issue Nov 1, 2022
@afeatherstone-mm
Add support for WPA3 (SAE) on Linux
1496509 
wpa_supplicant will use SAE, if required by the network. Support for
WPA3 is required as part of v1.0 of the Matter Specification (refer to
11.8.8.4 for details).

Resolves project-chip#23402.
afeatherstone-mm added a commit to afeatherstone-mm/connectedhomeip that referenced this issue Nov 1, 2022
@afeatherstone-mm
Add support for WPA3 (SAE) on Linux
1383ccf 
wpa_supplicant will use SAE, if required by the network. Support for
WPA3 is required as part of v1.0 of the Matter Specification (refer to
11.8.8.4 for details).

Resolves project-chip#23402.
afeatherstone-mm added a commit to afeatherstone-mm/connectedhomeip that referenced this issue Nov 2, 2022
@afeatherstone-mm
Add support for WPA3 (SAE) on Linux
87cc85a 
wpa_supplicant will use SAE, if required by the network. Support for
WPA3 is required as part of v1.0 of the Matter Specification (refer to
11.8.8.4 for details).

Resolves project-chip#23402.
afeatherstone-mm added a commit to afeatherstone-mm/connectedhomeip that referenced this issue Nov 2, 2022
@afeatherstone-mm
Add support for WPA3 (SAE) on Linux
fcb8d00 
wpa_supplicant will use SAE, if required by the network. Support for
WPA3 is required as part of v1.0 of the Matter Specification (refer to
11.8.8.4 for details).

Resolves project-chip#23402.
afeatherstone-mm added a commit to afeatherstone-mm/connectedhomeip that referenced this issue Nov 3, 2022
@afeatherstone-mm
Add support for WPA3 (SAE) on Linux
322bec4 
wpa_supplicant will use SAE, if required by the network. Support for
WPA3 is required as part of v1.0 of the Matter Specification (refer to
11.8.8.4 for details).

Resolves project-chip#23402.
@stale
Copy link

stale bot commented Apr 30, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Apr 30, 2023
@stale
Copy link

stale bot commented May 8, 2023

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed May 8, 2023
mergify bot pushed a commit that referenced this issue Nov 17, 2023
@afeatherstone-mm @andy31415
Add support for WPA3 (SAE) on Linux (#23404)
dca4271 
wpa_supplicant will use SAE, if required by the network. Support for
WPA3 is required as part of v1.0 of the Matter Specification (refer to
11.8.8.4 for details).

Resolves #23402.

Co-authored-by: Andrei Litvin <andy314@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
linux stale Stale issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for WPA3 (SAE) on Linux afeatherstone-mm/connectedhomeip
2 participants
@bzbarsky-apple @afeatherstone-mm