Add MTR_NEWLY_AVAILABLE to MTRLevelControlOptions #23680
Comments
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Dec 14, 2022
The changes to the generated code are as follows:
* MTRBaseClusters.h:
* Some newlines after MTR_NEWLY_AVAILABLE were removed. This led to a
smaller diff than adding blank lines in all the places that do not use
MTR_NEWLY_AVAILABLE. The newlines will return once we add availability
annotations to everything we shipped in the initial Matter release, in a
followup.
* MTRLevelControlOptions gained the availability annotation it was missing.
* Enum and bitmap values now have availability annotations.
* MTRClusterConstants.h:
* ClientMonitoring bits that should not have been generated (because it was
added after we made the API changes that those bits are backwards compat
shims for) were removed.
* The availability annotations on
MTRClusterDescriptorAttributeDeviceTypeListID got reordered (because the
new autogenerated things put API_AVAILABLE before the deprecation
annotation).
* MTRClusters.h:
* Some newlines after MTR_NEWLY_AVAILABLE were removed, similar to
MTRBaseClusters.h.
* Various selectors on clusters that have been newly added (e.g. due to
renames) now have the right availability annotations. Most of the diff
here is from the UnitTesting cluster.
* Some typos in deprecation messages ("writeAtribute" instead of
"writeAttribute" were fixed).
* MTRCommandPayloadsObjc.h
* Commands fields now have availability annotations.
* MTRClientMonitoringClusterRegisterClientMonitoringParams and
MTRClientMonitoringClusterStayAwakeRequestParams gained the availability
annotation they were missing.
* MTRStructsObjc.h
* Struct fields now have availability annotations.
* Deprecation annotation added to MTRDescriptorClusterDeviceType.
* MTRClientMonitoringClusterMonitoringRegistration gained the availability
annotation it was missing.
* Fixes project-chip#23880
* Fixes project-chip#23680
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Dec 15, 2022
The changes to the generated code are as follows:
* MTRBaseClusters.h:
* Some newlines after MTR_NEWLY_AVAILABLE were removed. This led to a
smaller diff than adding blank lines in all the places that do not use
MTR_NEWLY_AVAILABLE. The newlines will return once we add availability
annotations to everything we shipped in the initial Matter release, in a
followup.
* MTRLevelControlOptions gained the availability annotation it was missing.
* Enum and bitmap values now have availability annotations.
* MTRClusterConstants.h:
* ClientMonitoring bits that should not have been generated (because it was
added after we made the API changes that those bits are backwards compat
shims for) were removed.
* The availability annotations on
MTRClusterDescriptorAttributeDeviceTypeListID got reordered (because the
new autogenerated things put API_AVAILABLE before the deprecation
annotation).
* MTRClusters.h:
* Some newlines after MTR_NEWLY_AVAILABLE were removed, similar to
MTRBaseClusters.h.
* Various selectors on clusters that have been newly added (e.g. due to
renames) now have the right availability annotations. Most of the diff
here is from the UnitTesting cluster.
* Some typos in deprecation messages ("writeAtribute" instead of
"writeAttribute" were fixed).
* MTRCommandPayloadsObjc.h
* Commands fields now have availability annotations.
* MTRClientMonitoringClusterRegisterClientMonitoringParams and
MTRClientMonitoringClusterStayAwakeRequestParams gained the availability
annotation they were missing.
* MTRStructsObjc.h
* Struct fields now have availability annotations.
* Deprecation annotation added to MTRDescriptorClusterDeviceType.
* MTRClientMonitoringClusterMonitoringRegistration gained the availability
annotation it was missing.
* Fixes project-chip#23880
* Fixes project-chip#23680
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Dec 16, 2022
The changes to the generated code are as follows:
* MTRBaseClusters.h:
* Some newlines after MTR_NEWLY_AVAILABLE were removed. This led to a
smaller diff than adding blank lines in all the places that do not use
MTR_NEWLY_AVAILABLE. The newlines will return once we add availability
annotations to everything we shipped in the initial Matter release, in a
followup.
* MTRLevelControlOptions gained the availability annotation it was missing.
* Enum and bitmap values now have availability annotations.
* MTRClusterConstants.h:
* ClientMonitoring bits that should not have been generated (because it was
added after we made the API changes that those bits are backwards compat
shims for) were removed.
* The availability annotations on
MTRClusterDescriptorAttributeDeviceTypeListID got reordered (because the
new autogenerated things put API_AVAILABLE before the deprecation
annotation).
* MTRClusters.h:
* Some newlines after MTR_NEWLY_AVAILABLE were removed, similar to
MTRBaseClusters.h.
* Various selectors on clusters that have been newly added (e.g. due to
renames) now have the right availability annotations. Most of the diff
here is from the UnitTesting cluster.
* Some typos in deprecation messages ("writeAtribute" instead of
"writeAttribute" were fixed).
* MTRCommandPayloadsObjc.h
* Commands fields now have availability annotations.
* MTRClientMonitoringClusterRegisterClientMonitoringParams and
MTRClientMonitoringClusterStayAwakeRequestParams gained the availability
annotation they were missing.
* MTRStructsObjc.h
* Struct fields now have availability annotations.
* Deprecation annotation added to MTRDescriptorClusterDeviceType.
* MTRClientMonitoringClusterMonitoringRegistration gained the availability
annotation it was missing.
* Fixes project-chip#23880
* Fixes project-chip#23680
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Dec 16, 2022
The changes to the generated code are as follows:
* MTRBaseClusters.h:
* Some newlines after MTR_NEWLY_AVAILABLE were removed. This led to a
smaller diff than adding blank lines in all the places that do not use
MTR_NEWLY_AVAILABLE. The newlines will return once we add availability
annotations to everything we shipped in the initial Matter release, in a
followup.
* MTRLevelControlOptions gained the availability annotation it was missing.
* Enum and bitmap values now have availability annotations.
* MTRClusterConstants.h:
* ClientMonitoring bits that should not have been generated (because it was
added after we made the API changes that those bits are backwards compat
shims for) were removed.
* The availability annotations on
MTRClusterDescriptorAttributeDeviceTypeListID got reordered (because the
new autogenerated things put API_AVAILABLE before the deprecation
annotation).
* MTRClusters.h:
* Some newlines after MTR_NEWLY_AVAILABLE were removed, similar to
MTRBaseClusters.h.
* Various selectors on clusters that have been newly added (e.g. due to
renames) now have the right availability annotations. Most of the diff
here is from the UnitTesting cluster.
* Some typos in deprecation messages ("writeAtribute" instead of
"writeAttribute" were fixed).
* MTRCommandPayloadsObjc.h
* Commands fields now have availability annotations.
* MTRClientMonitoringClusterRegisterClientMonitoringParams and
MTRClientMonitoringClusterStayAwakeRequestParams gained the availability
annotation they were missing.
* MTRStructsObjc.h
* Struct fields now have availability annotations.
* Deprecation annotation added to MTRDescriptorClusterDeviceType.
* MTRClientMonitoringClusterMonitoringRegistration gained the availability
annotation it was missing.
* Fixes project-chip#23880
* Fixes project-chip#23680
bzbarsky-apple
added a commit
that referenced
this issue
Dec 16, 2022
* Auto-generate availability annotations for Darwin.
The changes to the generated code are as follows:
* MTRBaseClusters.h:
* Some newlines after MTR_NEWLY_AVAILABLE were removed. This led to a
smaller diff than adding blank lines in all the places that do not use
MTR_NEWLY_AVAILABLE. The newlines will return once we add availability
annotations to everything we shipped in the initial Matter release, in a
followup.
* MTRLevelControlOptions gained the availability annotation it was missing.
* Enum and bitmap values now have availability annotations.
* MTRClusterConstants.h:
* ClientMonitoring bits that should not have been generated (because it was
added after we made the API changes that those bits are backwards compat
shims for) were removed.
* The availability annotations on
MTRClusterDescriptorAttributeDeviceTypeListID got reordered (because the
new autogenerated things put API_AVAILABLE before the deprecation
annotation).
* MTRClusters.h:
* Some newlines after MTR_NEWLY_AVAILABLE were removed, similar to
MTRBaseClusters.h.
* Various selectors on clusters that have been newly added (e.g. due to
renames) now have the right availability annotations. Most of the diff
here is from the UnitTesting cluster.
* Some typos in deprecation messages ("writeAtribute" instead of
"writeAttribute" were fixed).
* MTRCommandPayloadsObjc.h
* Commands fields now have availability annotations.
* MTRClientMonitoringClusterRegisterClientMonitoringParams and
MTRClientMonitoringClusterStayAwakeRequestParams gained the availability
annotation they were missing.
* MTRStructsObjc.h
* Struct fields now have availability annotations.
* Deprecation annotation added to MTRDescriptorClusterDeviceType.
* MTRClientMonitoringClusterMonitoringRegistration gained the availability
annotation it was missing.
* Fixes #23880
* Fixes #23680
* Address review comments:
* Put the availability data filename in templates.json.
* Deprecation of a container should deprecate all its contents.
* Add renames as well.
* Update to containers with newer ZAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See comment:
#23656 (comment)
The text was updated successfully, but these errors were encountered: